From: Yi Liu <yi.l.liu@intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Cc: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"eric.auger@redhat.com" <eric.auger@redhat.com>,
"nicolinc@nvidia.com" <nicolinc@nvidia.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>
Subject: Re: [PATCH 2/2] iommu: Undo pasid attachment only for the devices that have succeeded
Date: Thu, 28 Mar 2024 14:29:14 +0800 [thread overview]
Message-ID: <e234b46f-e886-43eb-84f1-1eb1b7eb4fe4@intel.com> (raw)
In-Reply-To: <BN9PR11MB5276AB09D5A9E183C3492AD18C3B2@BN9PR11MB5276.namprd11.prod.outlook.com>
On 2024/3/28 11:15, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Wednesday, March 27, 2024 8:55 PM
>> +
>> +err_revert:
>> + last_gdev = device;
>> + for_each_group_device(group, device) {
>> + if (device == last_gdev)
>> + break;
>> + dev_iommu_ops(device->dev)->remove_dev_pasid(device-
>>> dev,
>> + pasid, domain);
>> + }
>
> break the long line into:
> ops = dev_iommu_ops(device->dev);
> ops->remove_dev_pasid();
got it.
> otherwise it looks good to me:
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
--
Regards,
Yi Liu
prev parent reply other threads:[~2024-03-28 6:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 12:54 [PATCH 0/2] Two enhancements to iommu_at[de]tach_device_pasid() Yi Liu
2024-03-27 12:54 ` [PATCH 1/2] iommu: Pass domain to remove_dev_pasid() op Yi Liu
2024-03-27 13:02 ` Jason Gunthorpe
2024-03-27 13:10 ` Yi Liu
2024-03-28 12:38 ` Yi Liu
2024-03-28 3:12 ` Tian, Kevin
2024-03-28 6:28 ` Yi Liu
2024-03-27 12:54 ` [PATCH 2/2] iommu: Undo pasid attachment only for the devices that have succeeded Yi Liu
2024-03-27 13:05 ` Jason Gunthorpe
2024-03-27 13:12 ` Yi Liu
2024-03-28 3:15 ` Tian, Kevin
2024-03-28 6:29 ` Yi Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e234b46f-e886-43eb-84f1-1eb1b7eb4fe4@intel.com \
--to=yi.l.liu@intel.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@intel.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox