From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Sean Christopherson <seanjc@google.com>,
"Li, Xin3" <xin3.li@intel.com>,
"linux-kernel@vger.kernnel.org" <linux-kernel@vger.kernnel.org>,
"x86@kernel.org" <x86@kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>
Subject: Re: [PATCH 5/6] KVM: x86/VMX: add kvm_vmx_reinject_nmi_irq() for NMI/IRQ reinjection
Date: Fri, 11 Nov 2022 13:17:02 +0100 [thread overview]
Message-ID: <e9ed7f8e-7236-c951-7a3d-c8128726c7d7@redhat.com> (raw)
In-Reply-To: <Y247mQq0uAtFqCFQ@hirez.programming.kicks-ass.net>
On 11/11/22 13:10, Peter Zijlstra wrote:
> *phew*, that sounds a*lot* better than 'random'. And yes, that should
> do.
>
> Another thing; these patches appear to be about system vectors and
> everything, but what I understand from Andrew is that VMX is only screwy
> vs NMI, not regular interrupts/exceptions, so where does that come from?
Exceptions are fine, for interrupts it's optional in theory but in
practice you have to invoke them manually just like NMIs (I had replied
on this in the other thread).
Paolo
> SVM specifically fixed the NMI wonkyness with their Global Interrupt
> flag thingy.
>
next prev parent reply other threads:[~2022-11-11 12:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 5:53 [PATCH 0/6] x86/traps,VMX: implement software based NMI/IRQ dispatch for VMX NMI/IRQ reinjection Xin Li
2022-11-10 5:53 ` [PATCH 1/6] x86/traps: let common_interrupt() handle IRQ_MOVE_CLEANUP_VECTOR Xin Li
2022-11-10 5:53 ` [PATCH 2/6] x86/traps: add a system interrupt table for system interrupt dispatch Xin Li
2022-11-10 5:53 ` [PATCH 3/6] x86/traps: add install_system_interrupt_handler() Xin Li
2022-11-10 5:53 ` [PATCH 4/6] x86/traps: add external_interrupt() to dispatch external interrupts Xin Li
2022-11-10 5:53 ` [PATCH 5/6] KVM: x86/VMX: add kvm_vmx_reinject_nmi_irq() for NMI/IRQ reinjection Xin Li
2022-11-10 15:59 ` Sean Christopherson
2022-11-10 20:40 ` Li, Xin3
2022-11-10 20:53 ` Sean Christopherson
2022-11-11 9:19 ` Peter Zijlstra
2022-11-11 9:29 ` H. Peter Anvin
2022-11-11 10:45 ` Peter Zijlstra
2022-11-11 11:57 ` Paolo Bonzini
2022-11-11 12:10 ` Peter Zijlstra
2022-11-11 12:17 ` Paolo Bonzini [this message]
2022-11-14 4:10 ` Li, Xin3
2022-11-14 2:18 ` Li, Xin3
2022-11-10 5:53 ` [PATCH 6/6] x86/traps: remove unused NMI entry exc_nmi_noist() Xin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9ed7f8e-7236-c951-7a3d-c8128726c7d7@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernnel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox