public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Frank Arnold <frank.arnold@amd.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Fix display of package version for KVM
Date: Fri, 18 Sep 2009 17:35:39 +0200	[thread overview]
Message-ID: <m3d45ofepg.fsf@neno.mitica> (raw)
In-Reply-To: <1253284704.3066.72.camel@mendozza.osrc.amd.com> (Frank Arnold's message of "Fri, 18 Sep 2009 16:38:24 +0200")

Frank Arnold <frank.arnold@amd.com> wrote:
> The configure script is constructing the pkgversion correctly.
> Due to some merge the same variable is getting purged again some
> lines later.
>
> Removing this line makes things work again.
>
> Signed-off-by: Frank Arnold <frank.arnold@amd.com>
> Acked-by: Andre Przywara <andre.przywara@amd.com>

Agreed.  I sent this same patch in the midle of my cleanup series.


> ---
>  configure |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 97292d9..c80c6a5 100755
> --- a/configure
> +++ b/configure
> @@ -238,7 +238,6 @@ signalfd="no"
>  eventfd="no"
>  cpu_emulation="yes"
>  kvm_kmod="no"
> -pkgversion=""
>  check_utests="no"
>  user_pie="no"

      reply	other threads:[~2009-09-18 15:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-18 14:38 [PATCH] Fix display of package version for KVM Frank Arnold
2009-09-18 15:35 ` Juan Quintela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3d45ofepg.fsf@neno.mitica \
    --to=quintela@redhat.com \
    --cc=frank.arnold@amd.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox