public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix display of package version for KVM
@ 2009-09-18 14:38 Frank Arnold
  2009-09-18 15:35 ` Juan Quintela
  0 siblings, 1 reply; 2+ messages in thread
From: Frank Arnold @ 2009-09-18 14:38 UTC (permalink / raw)
  To: kvm

The configure script is constructing the pkgversion correctly.
Due to some merge the same variable is getting purged again some
lines later.

Removing this line makes things work again.

Signed-off-by: Frank Arnold <frank.arnold@amd.com>
Acked-by: Andre Przywara <andre.przywara@amd.com>
---
 configure |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index 97292d9..c80c6a5 100755
--- a/configure
+++ b/configure
@@ -238,7 +238,6 @@ signalfd="no"
 eventfd="no"
 cpu_emulation="yes"
 kvm_kmod="no"
-pkgversion=""
 check_utests="no"
 user_pie="no"
 
-- 
1.6.0.6



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix display of package version for KVM
  2009-09-18 14:38 [PATCH] Fix display of package version for KVM Frank Arnold
@ 2009-09-18 15:35 ` Juan Quintela
  0 siblings, 0 replies; 2+ messages in thread
From: Juan Quintela @ 2009-09-18 15:35 UTC (permalink / raw)
  To: Frank Arnold; +Cc: kvm

Frank Arnold <frank.arnold@amd.com> wrote:
> The configure script is constructing the pkgversion correctly.
> Due to some merge the same variable is getting purged again some
> lines later.
>
> Removing this line makes things work again.
>
> Signed-off-by: Frank Arnold <frank.arnold@amd.com>
> Acked-by: Andre Przywara <andre.przywara@amd.com>

Agreed.  I sent this same patch in the midle of my cleanup series.


> ---
>  configure |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 97292d9..c80c6a5 100755
> --- a/configure
> +++ b/configure
> @@ -238,7 +238,6 @@ signalfd="no"
>  eventfd="no"
>  cpu_emulation="yes"
>  kvm_kmod="no"
> -pkgversion=""
>  check_utests="no"
>  user_pie="no"

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-18 15:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-18 14:38 [PATCH] Fix display of package version for KVM Frank Arnold
2009-09-18 15:35 ` Juan Quintela

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox