From: sashiko-bot@kernel.org
To: "Dmitry Voytik" <voytikd@gmail.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v2] coco/tdx-host: add Kconfig description
Date: Mon, 12 Oct 2026 18:05:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-168506@kernel.org> (raw)
In-Reply-To: <20261012175348.1256363-1-voytikd@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] kbuild: commit message claims to add Kconfig description but patch does not
--
commit 424217cd6059405518820db0188355121477942b
Author: Dmitry Voytik <voytikd@gmail.com>
coco/tdx-host: add Kconfig description
This commit updates the default value of the TDX_HOST_SERVICES Kconfig option
from 'm' to 'KVM_INTEL'. It is intended to fix an issue where the driver
always compiles as a module despite the user configuration.
> coco/tdx-host: add Kconfig description
> diff --git a/drivers/virt/coco/tdx-host/Kconfig b/drivers/virt/coco/tdx-host/Kconfig
> index 57d0c01a43577..fe018e00822b3 100644
> --- a/drivers/virt/coco/tdx-host/Kconfig
> +++ b/drivers/virt/coco/tdx-host/Kconfig
> @@ -3,4 +3,4 @@ config TDX_HOST_SERVICES
> depends on INTEL_TDX_HOST
> select FW_LOADER
> select FW_UPLOAD
> - default m
> + default KVM_INTEL
[Severity: Medium]
The commit subject claims to add a Kconfig description, which typically implies
adding a prompt string (such as tristate "Intel TDX host services") to make
the symbol visible in menuconfig. However, the patch only modifies the default
value and leaves the symbol hidden.
Was the hunk adding the description accidentally dropped from this version of
the patch, or should the commit subject be updated to reflect only the default
value change?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261012175348.1256363-1-voytikd@gmail.com?part=1
next prev parent reply other threads:[~2026-10-12 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 17:53 [PATCH v2] coco/tdx-host: add Kconfig description Dmitry Voytik
2026-10-12 18:05 ` sashiko-bot [this message]
2026-10-12 19:42 ` Kiryl Shutsemau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-168506@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=voytikd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox