[PATCH v2] coco/tdx-host: add Kconfig description

[PATCH v2] coco/tdx-host: add Kconfig description

[Dmitry Voytik]

Fix the issue when the driver always gets compiled as a module.
How to reproduce the issue:
	make mrproper
	make defconfig
	./scripts/config \
	  -e CMA \
	  -e ALLOC \
	  -e KVM \
	  -e KVM_INTEL \
	  -e KVM_INTEL_TDX \
	  -e INTEL_TDX_HOST \
	  -e TDX_HOST_SERVICES \
	  --refresh
	make olddefconfig
	make mod2yesconfig
	grep '=m$' .config

	returns only this driver as module:
	  CONFIG_TDX_HOST_SERVICES=m

Signed-off-by: Dmitry Voytik <voytikd@gmail.com>
---
v2:
 * changed per Kiryl's suggestion:
   https://lore.kernel.org/lkml/aszHlWi_aLIh8r9F@thinkstation/
v1:
 *https://lore.kernel.org/lkml/20261003223237.513456-1-voytikd@gmail.com/
---
---
 drivers/virt/coco/tdx-host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virt/coco/tdx-host/Kconfig b/drivers/virt/coco/tdx-host/Kconfig
index 57d0c01a4357..fe018e00822b 100644
--- a/drivers/virt/coco/tdx-host/Kconfig
+++ b/drivers/virt/coco/tdx-host/Kconfig
@@ -3,4 +3,4 @@ config TDX_HOST_SERVICES
 	depends on INTEL_TDX_HOST
 	select FW_LOADER
 	select FW_UPLOAD
-	default m
+	default KVM_INTEL
-- 
2.56.0

Re: [PATCH v2] coco/tdx-host: add Kconfig description

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] kbuild: commit message claims to add Kconfig description but patch does not
--

commit 424217cd6059405518820db0188355121477942b
Author: Dmitry Voytik <voytikd@gmail.com>

coco/tdx-host: add Kconfig description

This commit updates the default value of the TDX_HOST_SERVICES Kconfig option
from 'm' to 'KVM_INTEL'. It is intended to fix an issue where the driver
always compiles as a module despite the user configuration.

> coco/tdx-host: add Kconfig description

> diff --git a/drivers/virt/coco/tdx-host/Kconfig b/drivers/virt/coco/tdx-host/Kconfig
> index 57d0c01a43577..fe018e00822b3 100644
> --- a/drivers/virt/coco/tdx-host/Kconfig
> +++ b/drivers/virt/coco/tdx-host/Kconfig
> @@ -3,4 +3,4 @@ config TDX_HOST_SERVICES
>  	depends on INTEL_TDX_HOST
>  	select FW_LOADER
>  	select FW_UPLOAD
> -	default m
> +	default KVM_INTEL

[Severity: Medium]
The commit subject claims to add a Kconfig description, which typically implies
adding a prompt string (such as tristate "Intel TDX host services") to make
the symbol visible in menuconfig. However, the patch only modifies the default
value and leaves the symbol hidden.

Was the hunk adding the description accidentally dropped from this version of
the patch, or should the commit subject be updated to reflect only the default
value change?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012175348.1256363-1-voytikd@gmail.com?part=1

Re: [PATCH v2] coco/tdx-host: add Kconfig description

[Kiryl Shutsemau]

On Mon, Oct 12, 2026 at 07:53:48PM +0200, Dmitry Voytik wrote:
> Fix the issue when the driver always gets compiled as a module.
> How to reproduce the issue:
> 	make mrproper
> 	make defconfig
> 	./scripts/config \
> 	  -e CMA \
> 	  -e ALLOC \
> 	  -e KVM \
> 	  -e KVM_INTEL \
> 	  -e KVM_INTEL_TDX \
> 	  -e INTEL_TDX_HOST \
> 	  -e TDX_HOST_SERVICES \
> 	  --refresh
> 	make olddefconfig
> 	make mod2yesconfig
> 	grep '=m$' .config
> 
> 	returns only this driver as module:
> 	  CONFIG_TDX_HOST_SERVICES=m
> 
> Signed-off-by: Dmitry Voytik <voytikd@gmail.com>

Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>

-- 
  Kiryl Shutsemau / Kirill A. Shutemov