* [PATCH] KVM: PPC: remove unnecessary #ifdef
@ 2026-11-20 13:34 Paolo Bonzini
2026-11-22 3:43 ` Ritesh Harjani
2026-11-22 4:08 ` Madhavan Srinivasan
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2026-11-20 13:34 UTC (permalink / raw)
To: linux-kernel, kvm
booke.o is only built as part of kvm-e500-objs (which is conditional
on $(CONFIG_KVM_E500V2)) or kvm-e500mc-objs (likewise conditional
on $(CONFIG_KVM_E500MC)). Thus, the #ifdef in kvmppc_core_check_requests
is always true. Remove it.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
arch/powerpc/kvm/booke.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index fd7f24a68b31..ba762ac1fb56 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -738,10 +738,8 @@ int kvmppc_core_check_requests(struct kvm_vcpu *vcpu)
if (kvm_check_request(KVM_REQ_PENDING_TIMER, vcpu))
update_timer_ints(vcpu);
-#if defined(CONFIG_KVM_E500V2) || defined(CONFIG_KVM_E500MC)
if (kvm_check_request(KVM_REQ_TLB_FLUSH, vcpu))
kvmppc_core_flush_tlb(vcpu);
-#endif
if (kvm_check_request(KVM_REQ_WATCHDOG, vcpu)) {
vcpu->run->exit_reason = KVM_EXIT_WATCHDOG;
--
2.56.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: PPC: remove unnecessary #ifdef
2026-11-20 13:34 [PATCH] KVM: PPC: remove unnecessary #ifdef Paolo Bonzini
@ 2026-11-22 3:43 ` Ritesh Harjani
2026-11-22 4:08 ` Madhavan Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: Ritesh Harjani @ 2026-11-22 3:43 UTC (permalink / raw)
To: Paolo Bonzini, linux-kernel, kvm, linuxppc-dev
++ linuxppc-dev
Paolo Bonzini <pbonzini@redhat.com> writes:
> booke.o is only built as part of kvm-e500-objs (which is conditional
> on $(CONFIG_KVM_E500V2)) or kvm-e500mc-objs (likewise conditional
> on $(CONFIG_KVM_E500MC)). Thus, the #ifdef in kvmppc_core_check_requests
> is always true. Remove it.
>
That is correct. Looks like after KVM_440 removal via the following
commit, the above is always true.
commit b2677b8dd8de0dc1496ede4da09b9dfd59f15cea
Author: Alexander Graf <agraf@suse.de>
Date: Fri Jul 25 10:38:59 2014 +0200
KVM: PPC: Remove 440 support
Thanks for spotting it. LGTM. Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: PPC: remove unnecessary #ifdef
2026-11-20 13:34 [PATCH] KVM: PPC: remove unnecessary #ifdef Paolo Bonzini
2026-11-22 3:43 ` Ritesh Harjani
@ 2026-11-22 4:08 ` Madhavan Srinivasan
1 sibling, 0 replies; 3+ messages in thread
From: Madhavan Srinivasan @ 2026-11-22 4:08 UTC (permalink / raw)
To: Paolo Bonzini, linux-kernel, kvm, linuxppc-dev
++linuxppc-dev
On 11/20/26 7:04 PM, Paolo Bonzini wrote:
> booke.o is only built as part of kvm-e500-objs (which is conditional
> on $(CONFIG_KVM_E500V2)) or kvm-e500mc-objs (likewise conditional
> on $(CONFIG_KVM_E500MC)). Thus, the #ifdef in kvmppc_core_check_requests
> is always true. Remove it.
yes kvmppc_core_flush_tlb() is defined in e500_mmu.c which is
unconditionally linked in
both e500 config (kvm-e500mc-objs and kvm-e500-objs)
Nice catch. Thanks for the patch
Queued via PPC tree.
Maddy
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/powerpc/kvm/booke.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
> index fd7f24a68b31..ba762ac1fb56 100644
> --- a/arch/powerpc/kvm/booke.c
> +++ b/arch/powerpc/kvm/booke.c
> @@ -738,10 +738,8 @@ int kvmppc_core_check_requests(struct kvm_vcpu *vcpu)
>
> if (kvm_check_request(KVM_REQ_PENDING_TIMER, vcpu))
> update_timer_ints(vcpu);
> -#if defined(CONFIG_KVM_E500V2) || defined(CONFIG_KVM_E500MC)
> if (kvm_check_request(KVM_REQ_TLB_FLUSH, vcpu))
> kvmppc_core_flush_tlb(vcpu);
> -#endif
>
> if (kvm_check_request(KVM_REQ_WATCHDOG, vcpu)) {
> vcpu->run->exit_reason = KVM_EXIT_WATCHDOG;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-22 4:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 13:34 [PATCH] KVM: PPC: remove unnecessary #ifdef Paolo Bonzini
2026-11-22 3:43 ` Ritesh Harjani
2026-11-22 4:08 ` Madhavan Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox