[PATCH 0/2] KVM: arm64: Fix documentation for PSCI related functions

[PATCH 0/2] KVM: arm64: Fix documentation for PSCI related functions

[Fuad Tabba]

Hi,

This patch series fixes a couple of comments relating to PSCI and the reset
state that are either typos, or refer to an earlier version of the code.

Thanks,
/fuad

Fuad Tabba (2):
  KVM: arm64: Fix comment for kvm_reset_vcpu()
  KVM: arm64: Fix comment on barrier in kvm_psci_vcpu_on()

 arch/arm64/kvm/psci.c  | 2 +-
 arch/arm64/kvm/reset.c | 7 +++----
 2 files changed, 4 insertions(+), 5 deletions(-)


base-commit: 1f80d15020d7f130194821feb1432b67648c632d
-- 
2.34.1.400.ga245620fadb-goog

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

[PATCH 1/2] KVM: arm64: Fix comment for kvm_reset_vcpu()

[Fuad Tabba]

The comment for kvm_reset_vcpu() refers to the sysreg table as
being the table above, probably because of the code extracted at
commit f4672752c321ea36 ("arm64: KVM: virtual CPU reset").

Fix the comment to remove the potentially confusing reference.

Signed-off-by: Fuad Tabba <tabba@google.com>
---
 arch/arm64/kvm/reset.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c
index 426bd7fbc3fd..2bbfeadeb6ae 100644
--- a/arch/arm64/kvm/reset.c
+++ b/arch/arm64/kvm/reset.c
@@ -193,10 +193,9 @@ static bool vcpu_allowed_register_width(struct kvm_vcpu *vcpu)
  * kvm_reset_vcpu - sets core registers and sys_regs to reset value
  * @vcpu: The VCPU pointer
  *
- * This function finds the right table above and sets the registers on
- * the virtual CPU struct to their architecturally defined reset
- * values, except for registers whose reset is deferred until
- * kvm_arm_vcpu_finalize().
+ * This function sets the registers on the virtual CPU struct to their
+ * architecturally defined reset values, except for registers whose reset is
+ * deferred until kvm_arm_vcpu_finalize().
  *
  * Note: This function can be called from two paths: The KVM_ARM_VCPU_INIT
  * ioctl or as part of handling a request issued by another VCPU in the PSCI
-- 
2.34.1.400.ga245620fadb-goog

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

[PATCH 2/2] KVM: arm64: Fix comment on barrier in kvm_psci_vcpu_on()

[Fuad Tabba]

The barrier is there for power_off rather than power_state.
Probably typo in commit 358b28f09f0ab074 ("arm/arm64: KVM: Allow
a VCPU to fully reset itself").

Signed-off-by: Fuad Tabba <tabba@google.com>
---
 arch/arm64/kvm/psci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c
index 74c47d420253..9b82d6878aac 100644
--- a/arch/arm64/kvm/psci.c
+++ b/arch/arm64/kvm/psci.c
@@ -109,7 +109,7 @@ static unsigned long kvm_psci_vcpu_on(struct kvm_vcpu *source_vcpu)
 
 	/*
 	 * Make sure the reset request is observed if the change to
-	 * power_state is observed.
+	 * power_off is observed.
 	 */
 	smp_wmb();
 
-- 
2.34.1.400.ga245620fadb-goog

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [PATCH 0/2] KVM: arm64: Fix documentation for PSCI related functions

[Marc Zyngier]

On Wed, 8 Dec 2021 19:32:55 +0000, Fuad Tabba wrote:
> This patch series fixes a couple of comments relating to PSCI and the reset
> state that are either typos, or refer to an earlier version of the code.
> 
> Thanks,
> /fuad
> 
> Fuad Tabba (2):
>   KVM: arm64: Fix comment for kvm_reset_vcpu()
>   KVM: arm64: Fix comment on barrier in kvm_psci_vcpu_on()
> 
> [...]

Applied to next, thanks!

[1/2] KVM: arm64: Fix comment for kvm_reset_vcpu()
      commit: a080e323be8d66415944ad862fcf750825f871e7
[2/2] KVM: arm64: Fix comment on barrier in kvm_psci_vcpu_on()
      commit: dda0190d7ff7f26c221f9ab1659a73d4517920e7

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.


_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm