From: Marc Zyngier <maz@kernel.org>
To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
James Morse <james.morse@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: [PATCH v4 10/10] KVM: arm64: Handle Apple M2 as not having HCR_EL2.NV1 implemented
Date: Mon, 22 Jan 2024 18:13:44 +0000 [thread overview]
Message-ID: <20240122181344.258974-11-maz@kernel.org> (raw)
In-Reply-To: <20240122181344.258974-1-maz@kernel.org>
Although the Apple M2 family of CPUs can have HCR_EL2.NV1 being
set and clear, with the change in trap behaviour being OK, they
explode spectacularily on an EL2 S1 page table using the nVHE
format. This is no good.
Let's pretend this HW doesn't have NV1, and move along.
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
arch/arm64/kernel/cpufeature.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
index 91249d20883b..0f29ac43c7a2 100644
--- a/arch/arm64/kernel/cpufeature.c
+++ b/arch/arm64/kernel/cpufeature.c
@@ -1796,7 +1796,23 @@ static bool unmap_kernel_at_el0(const struct arm64_cpu_capabilities *entry,
static bool has_nv1(const struct arm64_cpu_capabilities *entry, int scope)
{
- return !has_cpuid_feature(entry, scope);
+ /*
+ * Although the Apple M2 family appears to support NV1, the
+ * PTW barfs on the nVHE EL2 S1 page table format. Pretend
+ * that it doesn't support NV1 at all.
+ */
+ static const struct midr_range nv1_ni_list[] = {
+ MIDR_ALL_VERSIONS(MIDR_APPLE_M2_BLIZZARD),
+ MIDR_ALL_VERSIONS(MIDR_APPLE_M2_AVALANCHE),
+ MIDR_ALL_VERSIONS(MIDR_APPLE_M2_BLIZZARD_PRO),
+ MIDR_ALL_VERSIONS(MIDR_APPLE_M2_AVALANCHE_PRO),
+ MIDR_ALL_VERSIONS(MIDR_APPLE_M2_BLIZZARD_MAX),
+ MIDR_ALL_VERSIONS(MIDR_APPLE_M2_AVALANCHE_MAX),
+ {}
+ };
+
+ return !(has_cpuid_feature(entry, scope) ||
+ is_midr_in_range_list(read_cpuid_id(), nv1_ni_list));
}
#if defined(ID_AA64MMFR0_EL1_TGRAN_LPA2) && defined(ID_AA64MMFR0_EL1_TGRAN_2_SUPPORTED_LPA2)
--
2.39.2
next prev parent reply other threads:[~2024-01-22 18:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 18:13 [PATCH v4 00/10] arm64: Add support for FEAT_E2H0, or lack thereof Marc Zyngier
2024-01-22 18:13 ` [PATCH v4 01/10] arm64: Add macro to compose a sysreg field value Marc Zyngier
2024-02-08 11:40 ` Catalin Marinas
2024-01-22 18:13 ` [PATCH v4 02/10] arm64: cpufeatures: Correctly handle signed values Marc Zyngier
2024-02-08 12:13 ` Catalin Marinas
2024-01-22 18:13 ` [PATCH v4 03/10] arm64: cpufeature: Correctly display signed override values Marc Zyngier
2024-02-08 12:14 ` Catalin Marinas
2024-01-22 18:13 ` [PATCH v4 04/10] arm64: sysreg: Add layout for ID_AA64MMFR4_EL1 Marc Zyngier
2024-02-08 12:25 ` Catalin Marinas
2024-02-08 13:06 ` Miguel Luis
2024-02-08 13:15 ` Marc Zyngier
2024-01-22 18:13 ` [PATCH v4 05/10] arm64: cpufeature: Add ID_AA64MMFR4_EL1 handling Marc Zyngier
2024-02-08 12:25 ` Catalin Marinas
2024-01-22 18:13 ` [PATCH v4 06/10] arm64: cpufeature: Detect HCR_EL2.NV1 being RES0 Marc Zyngier
2024-02-08 12:26 ` Catalin Marinas
2024-02-08 12:27 ` Catalin Marinas
2024-02-12 12:48 ` Marek Szyprowski
2024-02-12 14:00 ` Marc Zyngier
2024-02-12 14:21 ` Marek Szyprowski
2024-01-22 18:13 ` [PATCH v4 07/10] arm64: Treat HCR_EL2.E2H as RES1 when ID_AA64MMFR4_EL1.E2H0 is negative Marc Zyngier
2024-02-08 12:27 ` Catalin Marinas
2024-01-22 18:13 ` [PATCH v4 08/10] KVM: arm64: Expose ID_AA64MMFR4_EL1 to guests Marc Zyngier
2024-01-22 18:13 ` [PATCH v4 09/10] KVM: arm64: Force guest's HCR_EL2.E2H RES1 when NV1 is not implemented Marc Zyngier
2024-01-22 18:13 ` Marc Zyngier [this message]
2024-02-08 12:29 ` [PATCH v4 10/10] KVM: arm64: Handle Apple M2 as not having HCR_EL2.NV1 implemented Catalin Marinas
2024-02-02 19:03 ` [PATCH v4 00/10] arm64: Add support for FEAT_E2H0, or lack thereof Oliver Upton
2024-02-08 12:30 ` Catalin Marinas
2024-02-08 15:24 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122181344.258974-11-maz@kernel.org \
--to=maz@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox