Linux KVM/arm64 development list
 help / color / mirror / Atom feed
* [kvm-unit-tests PATCH 0/2] arm/arm64: Use 'max' cpu and gic types
@ 2024-04-02 12:21 Andrew Jones
  2024-04-02 12:21 ` [kvm-unit-tests PATCH 1/2] arm/arm64: Use 'max' gic type Andrew Jones
  2024-04-02 12:21 ` [kvm-unit-tests PATCH 2/2] arm64: Use 'max' cpu type Andrew Jones
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Jones @ 2024-04-02 12:21 UTC (permalink / raw)
  To: kvmarm; +Cc: alexandru.elisei, eric.auger, nikos.nikoleris, shahuang

The arm64 'max' CPU type enables all features, so it makes sense to use
it for testing to ensure we're testing the latest models. The 'max' GIC
is used to pick the latest GIC model by default which is better than
defaulting to gicv2 since it tests a later model and, when more
than 8 CPUs are configured, it'll actually work. We don't need to
convert 'max' to 'host' with KVM/HVF since 'max' is an alias for
'host' when those accelerators are enabled.

Andrew Jones (2):
  arm/arm64: Use 'max' gic type
  arm64: Use 'max' cpu type

 arm/run   | 8 +-------
 configure | 2 +-
 2 files changed, 2 insertions(+), 8 deletions(-)

-- 
2.44.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [kvm-unit-tests PATCH 1/2] arm/arm64: Use 'max' gic type
  2024-04-02 12:21 [kvm-unit-tests PATCH 0/2] arm/arm64: Use 'max' cpu and gic types Andrew Jones
@ 2024-04-02 12:21 ` Andrew Jones
  2024-04-02 12:21 ` [kvm-unit-tests PATCH 2/2] arm64: Use 'max' cpu type Andrew Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jones @ 2024-04-02 12:21 UTC (permalink / raw)
  To: kvmarm; +Cc: alexandru.elisei, eric.auger, nikos.nikoleris, shahuang

The 'max' GIC type has been supported for six years (Mar. 2018).
Ever since its introduction we've considered switching to it for the
default in the run scripts. Now, with commit 5dd20ec76ea6 ("runtime:
Update MAX_SMP probe"), we no longer always check and restrict
MAX_SMP, so we'd have better luck with configurations working by
default by finally doing the switch. Of course we also get the
benefits of testing more modern models by default and requiring less
command line modifications when converting TCG to KVM/HVF.

Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
---
 arm/run | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arm/run b/arm/run
index efdd44ce86a7..120e406fc703 100755
--- a/arm/run
+++ b/arm/run
@@ -29,13 +29,7 @@ if ! $qemu -machine '?' | grep -q 'ARM Virtual Machine'; then
 	exit 2
 fi
 
-M='-machine virt'
-
-if [ "$ACCEL" = "kvm" ]; then
-	if $qemu $M,\? | grep -q gic-version; then
-		M+=',gic-version=host'
-	fi
-fi
+M='-machine virt,gic-version=max'
 
 if [ "$ACCEL" = "kvm" ] || [ "$ACCEL" = "hvf" ]; then
 	if [ "$HOST" = "aarch64" ] || [ "$HOST" = "arm" ]; then
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [kvm-unit-tests PATCH 2/2] arm64: Use 'max' cpu type
  2024-04-02 12:21 [kvm-unit-tests PATCH 0/2] arm/arm64: Use 'max' cpu and gic types Andrew Jones
  2024-04-02 12:21 ` [kvm-unit-tests PATCH 1/2] arm/arm64: Use 'max' gic type Andrew Jones
@ 2024-04-02 12:21 ` Andrew Jones
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jones @ 2024-04-02 12:21 UTC (permalink / raw)
  To: kvmarm; +Cc: alexandru.elisei, eric.auger, nikos.nikoleris, shahuang

The 'max' GIC type has been supported for six years (Mar. 2018).
Ever since its introduction we've considered switching to it for the
default in the run scripts in order to test more modern models by
default. Let's finally do it!

(HVF's support for '-cpu max' is younger (only 2 years), but that
should also be old enough.)

Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 49f047cb2d7d..078271822b10 100755
--- a/configure
+++ b/configure
@@ -273,7 +273,7 @@ fi
 [ -z "$processor" ] && processor="$arch"
 
 if [ "$processor" = "arm64" ]; then
-    processor="cortex-a57"
+    processor="max"
 elif [ "$processor" = "arm" ]; then
     processor="cortex-a15"
 fi
-- 
2.44.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-02 12:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-02 12:21 [kvm-unit-tests PATCH 0/2] arm/arm64: Use 'max' cpu and gic types Andrew Jones
2024-04-02 12:21 ` [kvm-unit-tests PATCH 1/2] arm/arm64: Use 'max' gic type Andrew Jones
2024-04-02 12:21 ` [kvm-unit-tests PATCH 2/2] arm64: Use 'max' cpu type Andrew Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox