From: Marc Zyngier <maz@kernel.org>
To: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Cc: Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Zenghui Yu <yuzenghui@huawei.com>
Subject: [PATCH v2 0/6] KVM: arm64: EL2 PMU handling fixes
Date: Wed, 9 Apr 2025 17:01:00 +0100 [thread overview]
Message-ID: <20250409160106.6445-1-maz@kernel.org> (raw)
Joey reports that some of his PMU tests do not behave quite as
expected:
- MDCR_EL2.HPMN is set to 0 out of reset
- PMCR_EL0.P should reset all the counters when written from EL2
Oliver points out that setting PMCR_EL0.N from userspace by writing to
the register is silly with NV, and that we need a new PMU attribute
instead.
On top of that, I figured out that we had a number of little gotchas:
- It is possible for a guest to write an HPMN value that is out of
bound, and it seems valuable to limit it
- PMCR_EL0.N should be the maximum number of counters when read from
EL2, and MDCR_EL2.HPMN when read from EL0/EL1
- Prevent userspace from updating PMCR_EL0.N when EL2 is available
I haven't added any Cc stable, as NV is not functional upstream yet.
* From v1 [1]:
- Added patch for the new PMU attribute
- Added fix for HPMN limit
- Prevent update of PMCR_EL0.N with NV
- Fix kvm_vcpu_read_pmcr()
- Rebased on 6.15-rc1
[1] https://lore.kernel.org/r/20250217112412.3963324-1-maz@kernel.org
Marc Zyngier (6):
KVM: arm64: Fix MDCR_EL2.HPMN reset value
KVM: arm64: Contextualise the handling of PMCR_EL0.P writes
KVM: arm64: Allow userspace to limit the number of PMU counters for
EL2 VMs
KVM: arm64: Don't let userspace write to PMCR_EL0.N when the vcpu has
EL2
KVM: arm64: Handle out-of-bound write to HDCR_EL2.HPMN
KVM: arm64: Let kvm_vcpu_read_pmcr() return an EL-dependent value for
PMCR_EL0.N
Documentation/virt/kvm/devices/vcpu.rst | 24 ++++++++++++
arch/arm64/include/uapi/asm/kvm.h | 9 +++--
arch/arm64/kvm/pmu-emul.c | 51 ++++++++++++++++++++++---
arch/arm64/kvm/sys_regs.c | 43 ++++++++++++++++-----
4 files changed, 107 insertions(+), 20 deletions(-)
--
2.39.2
next reply other threads:[~2025-04-09 16:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 16:01 Marc Zyngier [this message]
2025-04-09 16:01 ` [PATCH v2 1/6] KVM: arm64: Fix MDCR_EL2.HPMN reset value Marc Zyngier
2025-04-09 20:21 ` Oliver Upton
2025-04-10 10:54 ` Marc Zyngier
2025-04-10 17:38 ` Oliver Upton
2025-04-09 16:01 ` [PATCH v2 2/6] KVM: arm64: Contextualise the handling of PMCR_EL0.P writes Marc Zyngier
2025-04-09 16:01 ` [PATCH v2 3/6] KVM: arm64: Allow userspace to limit the number of PMU counters for EL2 VMs Marc Zyngier
2025-04-09 20:25 ` Oliver Upton
2025-04-09 16:01 ` [PATCH v2 4/6] KVM: arm64: Don't let userspace write to PMCR_EL0.N when the vcpu has EL2 Marc Zyngier
2025-04-09 16:01 ` [PATCH v2 5/6] KVM: arm64: Handle out-of-bound write to HDCR_EL2.HPMN Marc Zyngier
2025-04-09 20:29 ` Oliver Upton
2025-04-09 16:01 ` [PATCH v2 6/6] KVM: arm64: Let kvm_vcpu_read_pmcr() return an EL-dependent value for PMCR_EL0.N Marc Zyngier
2025-04-09 20:31 ` [PATCH v2 0/6] KVM: arm64: EL2 PMU handling fixes Oliver Upton
2025-04-11 12:00 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250409160106.6445-1-maz@kernel.org \
--to=maz@kernel.org \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox