* [PATCH] KVM: arm64: nv: Release faulted-in VNCR page from mmu_lock critical section
@ 2025-05-21 11:04 Marc Zyngier
2025-05-23 11:01 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Marc Zyngier @ 2025-05-21 11:04 UTC (permalink / raw)
To: kvmarm, linux-arm-kernel
Cc: Joey Gouly, Suzuki K Poulose, Oliver Upton, Zenghui Yu
The conversion to kvm_release_faultin_page() missed the requirement
for this to be called within a critical section with mmu_lock held
for write. Move this call up to satisfy this requirement.
Fixes: 069a05e535496 ("KVM: arm64: nv: Handle VNCR_EL2-triggered faults")
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
arch/arm64/kvm/nested.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c
index 2381663d2ee98..e7e71f1615f19 100644
--- a/arch/arm64/kvm/nested.c
+++ b/arch/arm64/kvm/nested.c
@@ -1228,9 +1228,9 @@ static int kvm_translate_vncr(struct kvm_vcpu *vcpu)
vt->cpu = -1;
kvm_make_request(KVM_REQ_MAP_L1_VNCR_EL2, vcpu);
+ kvm_release_faultin_page(vcpu->kvm, page, false, vt->wr.pw);
}
- kvm_release_faultin_page(vcpu->kvm, page, false, vt->wr.pw);
if (vt->wr.pw)
mark_page_dirty(vcpu->kvm, gfn);
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: arm64: nv: Release faulted-in VNCR page from mmu_lock critical section
2025-05-21 11:04 [PATCH] KVM: arm64: nv: Release faulted-in VNCR page from mmu_lock critical section Marc Zyngier
@ 2025-05-23 11:01 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2025-05-23 11:01 UTC (permalink / raw)
To: kvmarm, linux-arm-kernel, Marc Zyngier
Cc: Joey Gouly, Suzuki K Poulose, Oliver Upton, Zenghui Yu
On Wed, 21 May 2025 12:04:35 +0100, Marc Zyngier wrote:
> The conversion to kvm_release_faultin_page() missed the requirement
> for this to be called within a critical section with mmu_lock held
> for write. Move this call up to satisfy this requirement.
>
>
Applied to next, thanks!
[1/1] KVM: arm64: nv: Release faulted-in VNCR page from mmu_lock critical section
commit: 538fbac74019c13dac341b20fbcc1e96c9a8d01e
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-23 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-21 11:04 [PATCH] KVM: arm64: nv: Release faulted-in VNCR page from mmu_lock critical section Marc Zyngier
2025-05-23 11:01 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox