Re: [PATCH 4/8] KVM: arm64: Move PSCI helper functions to a shared header

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The header `include/kvm/arm_psci.h` is not self-contained due to missing includes for dependencies used in the newly added inline functions.
--

commit 5533f45659b895d2266b9d4cfb6fd00ea1dc5f92
Author: Fuad Tabba <tabba@google.com>

KVM: arm64: Move PSCI helper functions to a shared header

This commit moves several PSCI helper functions out of psci.c and into the
shared include/kvm/arm_psci.h header. This includes kvm_psci_valid_affinity()
and kvm_psci_narrow_to_32bit(), along with renaming psci_affinity_mask().

[ ... ]

> diff --git a/include/kvm/arm_psci.h b/include/kvm/arm_psci.h
> index cbaec804eb839..f86a006d67136 100644
> --- a/include/kvm/arm_psci.h
> +++ b/include/kvm/arm_psci.h
> @@ -38,6 +38,33 @@ static inline int kvm_psci_version(struct kvm_vcpu *vcpu)
>  	return KVM_ARM_PSCI_0_1;
>  }
>  
> +/* Narrow the PSCI register arguments (r1 to r3) to 32 bits. */
> +static inline void kvm_psci_narrow_to_32bit(struct kvm_vcpu *vcpu)
> +{
> +	int i;
> +
> +	/*
> +	 * Zero the input registers' upper 32 bits. They will be fully
> +	 * zeroed on exit, so we're fine changing them in place.
> +	 */
> +	for (i = 1; i < 4; i++)
> +		vcpu_set_reg(vcpu, i, lower_32_bits(vcpu_get_reg(vcpu, i)));

[Severity: Low]
Does this change leave arm_psci.h relying on implicit includes?

The moved inline function kvm_psci_narrow_to_32bit() relies on vcpu_set_reg()
and vcpu_get_reg() which are defined in asm/kvm_emulate.h, as well as
lower_32_bits() which comes from linux/wordpart.h.

Should this header explicitly include those files to ensure it remains
self-contained, so that future users don't encounter build errors if they
include this file first?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260619070508.802802-1-tabba@google.com?part=4