Re: [kvmarm:fixes 18/18] arch/arm64/kvm/hyp/nvhe/mem_protect.c:1086:9: warning: variable 'ret' is uninitialized when used here

Re: [kvmarm:fixes 18/18] arch/arm64/kvm/hyp/nvhe/mem_protect.c:1086:9: warning: variable 'ret' is uninitialized when used here

[Marc Zyngier]

On Mon, 10 Feb 2025 09:44:02 +0000,
Quentin Perret <qperret@google.com> wrote:
> 
> On Monday 10 Feb 2025 at 09:21:29 (+0000), Marc Zyngier wrote:
> > On Mon, 10 Feb 2025 01:39:04 +0000,
> > kernel test robot <lkp@intel.com> wrote:
> > > 
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git fixes
> > > head:   eabc7aaef7a553b64bf6e631ce04526af6c8d104
> > > commit: eabc7aaef7a553b64bf6e631ce04526af6c8d104 [18/18] KVM: arm64: Simplify np-guest hypercalls
> > > config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20250210/202502100911.8c9DbtKD-lkp@intel.com/config)
> > > compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250210/202502100911.8c9DbtKD-lkp@intel.com/reproduce)
> > > 
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202502100911.8c9DbtKD-lkp@intel.com/
> > > 
> > > All warnings (new ones prefixed by >>):
> > > 
> > > >> arch/arm64/kvm/hyp/nvhe/mem_protect.c:1086:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
> > >     1086 |         return ret;
> > >          |                ^~~
> > >    arch/arm64/kvm/hyp/nvhe/mem_protect.c:1076:9: note: initialize the variable 'ret' to silence this warning
> > >     1076 |         int ret;
> > >          |                ^
> > >          |                 = 0
> > >    1 warning generated.
> > 
> > Nice catch. I wish the compiler would warn for these by default...
> 
> So do I...
> 
> > Quentin, are you happy with the following patch that I can stash on
> > top of the current set of fixes?
> 
> Absolutely, thanks for the patch and sorry the mess!
> 
>     Reviewed-by: Quentin Perret <qperret@google.com>

Now queued and pushed out.

LKP people: please fix the mailing address you are using, as it
changed over two years ago, and you're still using the old one.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [kvmarm:fixes 18/18] arch/arm64/kvm/hyp/nvhe/mem_protect.c:1086:9: warning: variable 'ret' is uninitialized when used here

[Philip Li]

On Mon, Feb 10, 2025 at 10:37:03AM +0000, Marc Zyngier wrote:
> On Mon, 10 Feb 2025 09:44:02 +0000,
> Quentin Perret <qperret@google.com> wrote:
> > 
> > On Monday 10 Feb 2025 at 09:21:29 (+0000), Marc Zyngier wrote:
> > > On Mon, 10 Feb 2025 01:39:04 +0000,
> > > kernel test robot <lkp@intel.com> wrote:

[...]

> 
> Now queued and pushed out.
> 
> LKP people: please fix the mailing address you are using, as it
> changed over two years ago, and you're still using the old one.

Got it, thanks for reminding this, we will update to use kvmarm@lists.linux.dev.

> 
> Thanks,
> 
> 	M.
> 
> -- 
> Without deviation from the norm, progress is not possible.
>