Re: [PATCH v2 07/19] KVM: arm64: vgic-its: Scope translation cache invalidations to an ITS

[Marc Zyngier <maz@kernel.org>]

On Fri, 19 Apr 2024 23:38:30 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
> 
> As the current LPI translation cache is global, the corresponding
> invalidation helpers are also globally-scoped. In anticipation of
> constructing a translation cache per ITS, add a helper for scoped cache
> invalidations.
> 
> We still need to support global invalidations when LPIs are toggled on
> a redistributor, as a property of the translation cache is that all
> stored LPIs are known to be delieverable.
> 
> Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
> ---
>  arch/arm64/kvm/vgic/vgic-its.c     | 45 ++++++++++++++++++++++--------
>  arch/arm64/kvm/vgic/vgic-mmio-v3.c |  2 +-
>  arch/arm64/kvm/vgic/vgic.h         |  2 +-
>  3 files changed, 35 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm64/kvm/vgic/vgic-its.c b/arch/arm64/kvm/vgic/vgic-its.c
> index 441134ad674e..4afd42b6a16c 100644
> --- a/arch/arm64/kvm/vgic/vgic-its.c
> +++ b/arch/arm64/kvm/vgic/vgic-its.c
> @@ -23,6 +23,8 @@
>  #include "vgic.h"
>  #include "vgic-mmio.h"
>  
> +static struct kvm_device_ops kvm_arm_vgic_its_ops;
> +
>  static int vgic_its_save_tables_v0(struct vgic_its *its);
>  static int vgic_its_restore_tables_v0(struct vgic_its *its);
>  static int vgic_its_commit_v0(struct vgic_its *its);
> @@ -616,7 +618,7 @@ static void vgic_its_cache_translation(struct kvm *kvm, struct vgic_its *its,
>  	raw_spin_unlock_irqrestore(&dist->lpi_list_lock, flags);
>  }
>  
> -void vgic_its_invalidate_cache(struct kvm *kvm)
> +static void vgic_its_invalidate_cache(struct vgic_its *its)
>  {
>  	struct vgic_dist *dist = &kvm->arch.vgic;

Err. How does this work? Looks like you got the patch splitting wrong
and that it doesn't bisect until patch #11.

	M.

-- 
Without deviation from the norm, progress is not possible.