Re: [PATCH 3/3] KVM: arm64: Don't translate FAR if invalid/unsafe

[Marc Zyngier <maz@kernel.org>]

On Wed, 02 Apr 2025 17:37:57 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
> 
> > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c
> > > index 2feb6c6b63af..754f2fe0cc67 100644
> > > --- a/arch/arm64/kvm/mmu.c
> > > +++ b/arch/arm64/kvm/mmu.c
> > > @@ -1794,9 +1794,28 @@ int kvm_handle_guest_abort(struct kvm_vcpu *vcpu)
> > >  	gfn_t gfn;
> > >  	int ret, idx;
> > >  
> > > +	/* Synchronous External Abort? */
> > > +	if (kvm_vcpu_abt_issea(vcpu)) {
> > > +		/*
> > > +		 * For RAS the host kernel may handle this abort.
> > > +		 * There is no need to pass the error into the guest.
> > > +		 */
> > > +		if (kvm_handle_guest_sea())
> > > +			kvm_inject_vabt(vcpu);
> > > +
> > > +		return 1;
> > > +	}
> > > +
> > 
> > Maybe add a line to the commit message to indicate that you're moving
> > this around?
> 
> I had this:
> 
>   Finally, fix up the rest of the abort path by checking for SEAs early
>   and bugging the VM if we get further along with an UNKNOWN fault IPA.
> 
> But I'm happy to expand a bit to make that more clear.

Ah, I somehow glanced over it. No need to change anything then.

Thanks,

	M.

-- 
Jazz isn't dead. It just smells funny.