Re: [PATCH v2 06/14] KVM: arm64: Call helper for reading descriptors directly

[Marc Zyngier <maz@kernel.org>]

On Mon, 17 Nov 2025 22:43:17 +0000,
Oliver Upton <oupton@kernel.org> wrote:
> 
> Going through a function pointer doesn't serve much purpose when there's
> only one implementation.
> 
> Signed-off-by: Oliver Upton <oupton@kernel.org>
> ---
>  arch/arm64/kvm/nested.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c
> index 08839a320a45..cf4b24e04a1a 100644
> --- a/arch/arm64/kvm/nested.c
> +++ b/arch/arm64/kvm/nested.c
> @@ -124,7 +124,6 @@ int kvm_vcpu_init_nested(struct kvm_vcpu *vcpu)
>  }
>  
>  struct s2_walk_info {
> -	int	     (*read_desc)(phys_addr_t pa, u64 *desc, void *data);
>  	void	     *data;
>  	u64	     baddr;
>  	unsigned int max_oa_bits;
> @@ -199,6 +198,15 @@ static int check_output_size(struct s2_walk_info *wi, phys_addr_t output)
>  	return 0;
>  }
>  
> +static int read_guest_s2_desc(phys_addr_t pa, u64 *desc, void *data)
> +{
> +	struct kvm_vcpu *vcpu = data;
> +	u64 val;
> +	int r;

Unused variables, better moved to the follow-up patch.

Thanks,

	M.

-- 
Jazz isn't dead. It just smells funny.