From: Oliver Upton <oliver.upton@linux.dev>
To: Fuad Tabba <tabba@google.com>
Cc: kvmarm@lists.linux.dev, maz@kernel.org, catalin.marinas@arm.com,
joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com,
will@kernel.org
Subject: Re: [PATCH v1 1/4] KVM: arm64: Move pkvm_vcpu_init_traps() to init_pkvm_hyp_vcpu()
Date: Tue, 15 Oct 2024 01:30:48 -0700 [thread overview]
Message-ID: <Zw4oOI7GzHnGjImP@linux.dev> (raw)
In-Reply-To: <CA+EHjTwLE+zpSKMMaRDNbuuBmvMJZZAFoha7hpiRuNhwgP60Ww@mail.gmail.com>
On Tue, Oct 15, 2024 at 09:22:47AM +0100, Fuad Tabba wrote:
> Hi Oliver,
>
> On Tue, 15 Oct 2024 at 08:37, Oliver Upton <oliver.upton@linux.dev> wrote:
> > Can we instead get rid of this hypercall by implementing the one-time
> > late initialization as the comment suggests?
>
> I'm not sure I understand. I thought this is what I'm doing in this patch...
You're more than welcome to say when I'm being a damn idiot, such as
right now :)
I've been staring at too much initialization code and forgot that the
hypervisor's view of the VM is created late and not at 'vCPU
initialization' i.e. KVM_ARM_VCPU_INIT.
> > It'd be great if the feature configuration for non-protected and
> > protected VMs is done in a similar way, and that is userspace changes to
> > the ID registers before KVM_RUN.
> >
> > So we need this sort of 'late' initialization for that behavior to work.
>
> I think this is related to me now quite understanding the first
> comment, and by extension not sure I quite get this one.
Sorry for the noise.
--
Thanks,
Oliver
next prev parent reply other threads:[~2024-10-15 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 10:24 [PATCH v1 0/4] KVM: arm64: Fix initialization of trap register values in pKVM Fuad Tabba
2024-10-14 10:24 ` [PATCH v1 1/4] KVM: arm64: Move pkvm_vcpu_init_traps() to init_pkvm_hyp_vcpu() Fuad Tabba
2024-10-15 7:37 ` Oliver Upton
2024-10-15 8:22 ` Fuad Tabba
2024-10-15 8:30 ` Oliver Upton [this message]
2024-10-15 9:35 ` Fuad Tabba
2024-10-14 10:24 ` [PATCH v1 2/4] KVM: arm64: Refactor kvm_vcpu_enable_ptrauth() for hyp use Fuad Tabba
2024-10-14 10:24 ` [PATCH v1 3/4] KVM: arm64: Initialize the hypervisor's VM state at EL2 Fuad Tabba
2024-10-14 10:24 ` [PATCH v1 4/4] KVM: arm64: Initialize trap register values in hyp in pKVM Fuad Tabba
2024-10-15 7:57 ` Oliver Upton
2024-10-15 8:19 ` Fuad Tabba
2024-10-15 8:22 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw4oOI7GzHnGjImP@linux.dev \
--to=oliver.upton@linux.dev \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox