Re: [PATCH] KVM: arm64: nv: Handle SEAs due to VNCR redirection

[Oliver Upton <oliver.upton@linux.dev>]

On Wed, Jul 30, 2025 at 10:54:50AM +0100, Marc Zyngier wrote:
> > diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c
> > index efb37aad11ec..4f741ba24b48 100644
> > --- a/arch/arm64/kvm/nested.c
> > +++ b/arch/arm64/kvm/nested.c
> > @@ -1289,6 +1289,9 @@ int kvm_handle_vncr_abort(struct kvm_vcpu *vcpu)
> >  
> >  	BUG_ON(!(esr & ESR_ELx_VNCR_SHIFT));
> 
> Urgh. This is hilarious. We don't trigger this thing by pure luck (13
> is a lucky number, apparently...). I'll post a separate fix for that.

LOL! I totally missed this when I wrote the patch. I'll grab your fix,
thx for posting.

> >  
> > +	if (kvm_vcpu_abt_issea(vcpu))
> > +		return kvm_handle_guest_sea(vcpu);
> > +
> >  	if (esr_fsc_is_permission_fault(esr)) {
> >  		inject_vncr_perm(vcpu);
> >  	} else if (esr_fsc_is_translation_fault(esr)) {
> > 
> 
> Reviewed-by: Marc Zyngier <maz@kernel.org>

Appreciated :)

Thanks,
Oliver