Linux KVM/arm64 development list
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: yuzenghui@huawei.com, christoffer.dall@arm.com, marc.zyngier@arm.com
Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT
Date: Thu, 14 Feb 2019 10:11:38 +0000	[thread overview]
Message-ID: <f14b90b1-ca81-e57e-9c42-6c8a4608cf72@arm.com> (raw)
In-Reply-To: <1550108746-14704-1-git-send-email-yuzenghui@huawei.com>

Hi

On 14/02/2019 01:45, Zenghui Yu wrote:
> Since Suzuki K Poulose's work on Dynamic IPA support, KVM_PHYS_SHIFT will
> be used only when machine_type's bits[7:0] equal to 0 (by default). Thus
> the outdated comment should be fixed.
> 
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
>   arch/arm64/include/asm/kvm_mmu.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h
> index 8af4b1b..a12bf48 100644
> --- a/arch/arm64/include/asm/kvm_mmu.h
> +++ b/arch/arm64/include/asm/kvm_mmu.h
> @@ -138,7 +138,8 @@ static inline unsigned long __kern_hyp_va(unsigned long v)
>   	})
>   
>   /*
> - * We currently only support a 40bit IPA.
> + * We currently support using a VM-specified IPA size. For backward
> + * compatibility, the default IPA size is fixed to 40bits.
>    */
>   #define KVM_PHYS_SHIFT	(40)

Thanks for the fix.

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

  reply	other threads:[~2019-02-14 10:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14  1:45 [PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT Zenghui Yu
2019-02-14 10:11 ` Suzuki K Poulose [this message]
2019-02-18  8:47   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f14b90b1-ca81-e57e-9c42-6c8a4608cf72@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=christoffer.dall@arm.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox