* [PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT
@ 2019-02-14 1:45 Zenghui Yu
2019-02-14 10:11 ` Suzuki K Poulose
0 siblings, 1 reply; 3+ messages in thread
From: Zenghui Yu @ 2019-02-14 1:45 UTC (permalink / raw)
To: christoffer.dall, marc.zyngier; +Cc: Zenghui Yu, kvmarm, linux-arm-kernel
Since Suzuki K Poulose's work on Dynamic IPA support, KVM_PHYS_SHIFT will
be used only when machine_type's bits[7:0] equal to 0 (by default). Thus
the outdated comment should be fixed.
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
arch/arm64/include/asm/kvm_mmu.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h
index 8af4b1b..a12bf48 100644
--- a/arch/arm64/include/asm/kvm_mmu.h
+++ b/arch/arm64/include/asm/kvm_mmu.h
@@ -138,7 +138,8 @@ static inline unsigned long __kern_hyp_va(unsigned long v)
})
/*
- * We currently only support a 40bit IPA.
+ * We currently support using a VM-specified IPA size. For backward
+ * compatibility, the default IPA size is fixed to 40bits.
*/
#define KVM_PHYS_SHIFT (40)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT
2019-02-14 1:45 [PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT Zenghui Yu
@ 2019-02-14 10:11 ` Suzuki K Poulose
2019-02-18 8:47 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Suzuki K Poulose @ 2019-02-14 10:11 UTC (permalink / raw)
To: yuzenghui, christoffer.dall, marc.zyngier; +Cc: kvmarm, linux-arm-kernel
Hi
On 14/02/2019 01:45, Zenghui Yu wrote:
> Since Suzuki K Poulose's work on Dynamic IPA support, KVM_PHYS_SHIFT will
> be used only when machine_type's bits[7:0] equal to 0 (by default). Thus
> the outdated comment should be fixed.
>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> arch/arm64/include/asm/kvm_mmu.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h
> index 8af4b1b..a12bf48 100644
> --- a/arch/arm64/include/asm/kvm_mmu.h
> +++ b/arch/arm64/include/asm/kvm_mmu.h
> @@ -138,7 +138,8 @@ static inline unsigned long __kern_hyp_va(unsigned long v)
> })
>
> /*
> - * We currently only support a 40bit IPA.
> + * We currently support using a VM-specified IPA size. For backward
> + * compatibility, the default IPA size is fixed to 40bits.
> */
> #define KVM_PHYS_SHIFT (40)
Thanks for the fix.
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT
2019-02-14 10:11 ` Suzuki K Poulose
@ 2019-02-18 8:47 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2019-02-18 8:47 UTC (permalink / raw)
To: Suzuki K Poulose; +Cc: yuzenghui, linux-arm-kernel, kvmarm
On Thu, 14 Feb 2019 10:11:38 +0000
Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
> Hi
>
> On 14/02/2019 01:45, Zenghui Yu wrote:
> > Since Suzuki K Poulose's work on Dynamic IPA support, KVM_PHYS_SHIFT will
> > be used only when machine_type's bits[7:0] equal to 0 (by default). Thus
> > the outdated comment should be fixed.
> > > Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> > Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> > ---
> > arch/arm64/include/asm/kvm_mmu.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h
> > index 8af4b1b..a12bf48 100644
> > --- a/arch/arm64/include/asm/kvm_mmu.h
> > +++ b/arch/arm64/include/asm/kvm_mmu.h
> > @@ -138,7 +138,8 @@ static inline unsigned long __kern_hyp_va(unsigned long v)
> > })
> > > /*
> > - * We currently only support a 40bit IPA.
> > + * We currently support using a VM-specified IPA size. For backward
> > + * compatibility, the default IPA size is fixed to 40bits.
> > */
> > #define KVM_PHYS_SHIFT (40)
>
> Thanks for the fix.
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Applied, thanks.
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-18 8:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-14 1:45 [PATCH] kvm: arm64: Fix comment for KVM_PHYS_SHIFT Zenghui Yu
2019-02-14 10:11 ` Suzuki K Poulose
2019-02-18 8:47 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).