Linux KVM/arm64 development list
 help / color / mirror / Atom feed
* [PATCH] KVM: arm64: selftests: Actually enable IRQs in vgic_lpi_stress
@ 2025-10-07 19:52 Oliver Upton
  2025-10-08 14:42 ` Zenghui Yu
  2025-10-13 16:56 ` Marc Zyngier
  0 siblings, 2 replies; 3+ messages in thread
From: Oliver Upton @ 2025-10-07 19:52 UTC (permalink / raw)
  To: kvmarm; +Cc: Marc Zyngier, Joey Gouly, Suzuki K Poulose, Zenghui Yu,
	Oliver Upton

vgic_lpi_stress rather hilariously leaves IRQs disabled for the duration
of the test. While the ITS translation of MSIs happens regardless of
this, for completeness the guest should actually handle the LPIs.

Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
---
 tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c b/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c
index 87922a89b134..b890d7d91de1 100644
--- a/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c
+++ b/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c
@@ -123,6 +123,7 @@ static void guest_setup_gic(void)
 static void guest_code(size_t nr_lpis)
 {
 	guest_setup_gic();
+	local_irq_enable();
 
 	GUEST_SYNC(0);
 

base-commit: 10fd0285305d0b48e8a3bf15d4f17fc4f3d68cb6
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] KVM: arm64: selftests: Actually enable IRQs in vgic_lpi_stress
  2025-10-07 19:52 [PATCH] KVM: arm64: selftests: Actually enable IRQs in vgic_lpi_stress Oliver Upton
@ 2025-10-08 14:42 ` Zenghui Yu
  2025-10-13 16:56 ` Marc Zyngier
  1 sibling, 0 replies; 3+ messages in thread
From: Zenghui Yu @ 2025-10-08 14:42 UTC (permalink / raw)
  To: Oliver Upton
  Cc: kvmarm, Marc Zyngier, Joey Gouly, Suzuki K Poulose, Zenghui Yu

On 2025/10/8 03:52, Oliver Upton wrote:
> vgic_lpi_stress rather hilariously leaves IRQs disabled for the duration
> of the test. While the ITS translation of MSIs happens regardless of
> this, for completeness the guest should actually handle the LPIs.
> 
> Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
> ---
>  tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c b/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c
> index 87922a89b134..b890d7d91de1 100644
> --- a/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c
> +++ b/tools/testing/selftests/kvm/arm64/vgic_lpi_stress.c
> @@ -123,6 +123,7 @@ static void guest_setup_gic(void)
>  static void guest_code(size_t nr_lpis)
>  {
>  	guest_setup_gic();
> +	local_irq_enable();
>  
>  	GUEST_SYNC(0);

Reviewed-by: Zenghui Yu <zenghui.yu@linux.dev>

Thanks,
Zenghui

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] KVM: arm64: selftests: Actually enable IRQs in vgic_lpi_stress
  2025-10-07 19:52 [PATCH] KVM: arm64: selftests: Actually enable IRQs in vgic_lpi_stress Oliver Upton
  2025-10-08 14:42 ` Zenghui Yu
@ 2025-10-13 16:56 ` Marc Zyngier
  1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2025-10-13 16:56 UTC (permalink / raw)
  To: kvmarm, Oliver Upton; +Cc: Joey Gouly, Suzuki K Poulose, Zenghui Yu

On Tue, 07 Oct 2025 12:52:55 -0700, Oliver Upton wrote:
> vgic_lpi_stress rather hilariously leaves IRQs disabled for the duration
> of the test. While the ITS translation of MSIs happens regardless of
> this, for completeness the guest should actually handle the LPIs.
> 
> 

Applied to fixes, thanks!

[1/1] KVM: arm64: selftests: Actually enable IRQs in vgic_lpi_stress
      commit: d5e6310a0d996493b1af9f3eeec418350523388b

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-13 16:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-07 19:52 [PATCH] KVM: arm64: selftests: Actually enable IRQs in vgic_lpi_stress Oliver Upton
2025-10-08 14:42 ` Zenghui Yu
2025-10-13 16:56 ` Marc Zyngier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox