From: David Given <dg@cowlark.com>
To: linux-8086@vger.kernel.org
Subject: Re: Broken-up patch #12
Date: Sat, 29 May 2004 02:31:44 +0100 [thread overview]
Message-ID: <40B7E800.10302@cowlark.com> (raw)
In-Reply-To: <Pine.LNX.4.58L.0405282054170.31184@damien.conectiva>
claudio@conectiva.com wrote:
[...]
> - if (c == '^V')
> + if (c == '^V ')
>
> It seems that this patch is doing funny things with the ^V character
> (changing it to a space, adding a space after it). Is it really what
> it is supposed to do, even if commenting the code chunk out?
That ^V scares me. Please tell me it's not a literal control character
in the actual source file. That would be very, very evil.
The alternative --- '^V' as four bytes --- is nearly as bad, because
that's a multicharacter constant that will show up either as a 16-bit
constant or an error message, neither of which will work. If it's
showing up as ASCII char 22, that is also evil, because your C compiler
shouldn't be doing that.
--
[insert interesting .sig here]
next prev parent reply other threads:[~2004-05-29 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-28 23:27 Broken-up patch #12 Tommy McCabe
2004-05-28 23:57 ` claudio
2004-05-29 1:31 ` David Given [this message]
2004-05-31 19:53 ` Broken-up patch #12, #8 and #7 Miguel Bolanos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40B7E800.10302@cowlark.com \
--to=dg@cowlark.com \
--cc=linux-8086@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox