Broken-up patch #12

Broken-up patch #12

[Tommy McCabe]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

Comments out more ' 's in levee. We should all switch
to e3.


	
		
__________________________________
Do you Yahoo!?
Friends.  Fun.  Try the all-new Yahoo! Messenger.
http://messenger.yahoo.com/ 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch12.diff --]
[-- Type: text/x-diff; name="patch12.diff", Size: 597 bytes --]

--- ./elks-stuff/elkscmd/levee/misc.c	2004-05-28 16:02:01.000000000 -0400
+++ ./elks/elkscmd/levee/misc.c	2004-05-28 19:25:13.000000000 -0400
@@ -392,10 +392,11 @@
 	    *size = (ip-start);
             return (c==ESC) ? ESC : EOL;
 	}
-	else if ((!beautify) || c == TAB || c == '\x16'
+	/*
+	else if ((!beautify) || c == TAB || c == ' '
 			     || (c >= ' ' && c <= '~')) {
 	    if (ip < endd) {
-		if (c == '\x16')
+		if (c == '\x16 ') 
 		    c = readchar();
 		switch (cclass(c)) {
 		    case 0 : ixp++; break;
@@ -412,6 +413,7 @@
 	    else
 		error();
 	}
+	*/
         else
 	    error();
     }

Re: Broken-up patch #12

[claudio]

On Fri, 28 May 2004, Tommy McCabe wrote:

> Comments out more ' 's in levee. We should all switch
> to e3.


-       else if ((!beautify) || c == TAB || c == '^V'
+       /*
+       else if ((!beautify) || c == TAB || c == ' '
                             || (c >= ' ' && c <= '~')) {
            if (ip < endd) {
-               if (c == '^V')
+               if (c == '^V ')

It seems that this patch is doing funny things with the ^V character
(changing it to a space, adding a space after it). Is it really what
it is supposed to do, even if commenting the code chunk out?

Re: Broken-up patch #12

[David Given]

claudio@conectiva.com wrote:
[...]
> -               if (c == '^V')
> +               if (c == '^V ')
> 
> It seems that this patch is doing funny things with the ^V character
> (changing it to a space, adding a space after it). Is it really what
> it is supposed to do, even if commenting the code chunk out?

That ^V scares me. Please tell me it's not a literal control character 
in the actual source file. That would be very, very evil.

The alternative --- '^V' as four bytes --- is nearly as bad, because 
that's a multicharacter constant that will show up either as a 16-bit 
constant or an error message, neither of which will work. If it's 
showing up as ASCII char 22, that is also evil, because your C compiler 
shouldn't be doing that.

-- 
[insert interesting .sig here]

Re: Broken-up patch #12, #8 and #7

[Miguel Bolanos]

Applied on Claudio,s finals.
thanks.

On Fri, 2004-05-28 at 17:27, Tommy McCabe wrote:
> Comments out more ' 's in levee. We should all switch
> to e3.
> 
> 
> 	
> 		
> __________________________________
> Do you Yahoo!?
> Friends.  Fun.  Try the all-new Yahoo! Messenger.
> http://messenger.yahoo.com/
> 
> ______________________________________________________________________
> --- ./elks-stuff/elkscmd/levee/misc.c	2004-05-28 16:02:01.000000000 -0400
> +++ ./elks/elkscmd/levee/misc.c	2004-05-28 19:25:13.000000000 -0400
> @@ -392,10 +392,11 @@
>  	    *size = (ip-start);
>              return (c==ESC) ? ESC : EOL;
>  	}
> -	else if ((!beautify) || c == TAB || c == '\x16'
> +	/*
> +	else if ((!beautify) || c == TAB || c == ' '
>  			     || (c >= ' ' && c <= '~')) {
>  	    if (ip < endd) {
> -		if (c == '\x16')
> +		if (c == '\x16 ') 
>  		    c = readchar();
>  		switch (cclass(c)) {
>  		    case 0 : ixp++; break;
> @@ -412,6 +413,7 @@
>  	    else
>  		error();
>  	}
> +	*/
>          else
>  	    error();
>      }