From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Riley@Williams.Name
Cc: Harry Kalogirou <harkal@gmx.net>,
Linux 8086 <linux-8086@vger.kernel.org>
Subject: Re: SPLINT: sys_open missing a parameter in init/main.c
Date: Mon, 29 Apr 2002 01:11:45 +0100 (BST) [thread overview]
Message-ID: <E171yle-0004y2-00@the-village.bc.nu> (raw)
In-Reply-To: <Pine.LNX.4.21.0204281819010.8763-100000@Consulate.UFP.CX> from "Riley Williams" at Apr 28, 2002 10:15:21 PM
> The funtion sys_open is defined with three parameters...
> int sys_open(char *filename, int flags, int mode);
>
> ...but in init/main.c it is called with only two parameters...
Thats sort of fine. The third parameter is optional in open() syscalls and
is the mode for creation. Historically ancient unix had creat() and no
3 argument open.
> ...and I haven't the foggiest how to correct this. Can somebody rather
> more knowledgable than I am advise regarding this please?
Stuff a ",0" on the end - its not needed but its good for correctness and
portability
next prev parent reply other threads:[~2002-04-29 0:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-28 21:15 SPLINT: sys_open missing a parameter in init/main.c Riley Williams
2002-04-28 22:32 ` Christoph Plattner
2002-04-29 0:11 ` Alan Cox [this message]
2002-04-29 21:20 ` Riley Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E171yle-0004y2-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Riley@Williams.Name \
--cc=harkal@gmx.net \
--cc=linux-8086@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox