From: Hanjun Guo <guohanjun@huawei.com>
To: Dave Jiang <dave.jiang@intel.com>, <lpieralisi@kernel.org>,
<sudeep.holla@arm.com>
Cc: kernel test robot <lkp@intel.com>,
Jianmin Lv <lvjianmin@loongson.cn>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
<rafael@kernel.org>, <lenb@kernel.org>,
<linux-acpi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acpi: Fix header declaration of acpi_arch_dma_setup() w/o CONFIG_ACPI
Date: Thu, 1 Jun 2023 09:48:32 +0800 [thread overview]
Message-ID: <0953941a-ad4e-ba7e-4f4e-64c47de71f0b@huawei.com> (raw)
In-Reply-To: <168477156440.3873520.6153672647621739139.stgit@djiang5-mobl3>
Hi Dave,
Sorry for the late reply, I have some comments inline.
On 2023/5/23 0:06, Dave Jiang wrote:
> arm64 build can be done without CONFIG_ACPI. The ifdef bits for
> acpi_arch_dma_setup() is placed inside CONFIG_ACPI. When CONFIG_ACPI is
> not set, this causes warning reported by kernel test bot. Move the
> prototype declaration for acpi_arch_dma_setup() outside of CONFIG_ACPI.
...
>
>>> drivers/acpi/arm64/dma.c:7:6: warning: no previous prototype for function 'acpi_arch_dma_setup' [-Wmissing-prototypes]
> void acpi_arch_dma_setup(struct device *dev)
> ^
> drivers/acpi/arm64/dma.c:7:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> void acpi_arch_dma_setup(struct device *dev)
> ^
> static
> 1 warning generated.
drivers/acpi can only be compiled with CONFIG_ACPI=y, so
drivers/acpi/arm64/ will be the same, not sure how to trigger
this compile warning.
I disable CONFIG_ACPI on my ARM64 machine, but didn't get the
warning you reported.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202305200933.afKCLlxS-lkp@intel.com/
How to generate the kernel config file as you kindly attached in the
link?
Thanks
Hanjun
next prev parent reply other threads:[~2023-06-01 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 16:06 [PATCH] acpi: Fix header declaration of acpi_arch_dma_setup() w/o CONFIG_ACPI Dave Jiang
2023-06-01 1:48 ` Hanjun Guo [this message]
2023-06-01 10:31 ` Robin Murphy
2023-06-01 15:24 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0953941a-ad4e-ba7e-4f4e-64c47de71f0b@huawei.com \
--to=guohanjun@huawei.com \
--cc=dave.jiang@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox