From: Prarit Bhargava <prarit@redhat.com>
To: Borislav Petkov <bp@suse.de>
Cc: linux-acpi@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ying.huang@intel.com
Subject: Re: [PATCH] acpi/apei/erst: Remove "Error" from initialization and disable output
Date: Tue, 18 Jul 2017 07:29:40 -0400 [thread overview]
Message-ID: <0fb91e9d-5446-aa6e-2eea-c455538c4c1a@redhat.com> (raw)
In-Reply-To: <20170718052627.GA8741@nazgul.tnic>
On 07/18/2017 01:26 AM, Borislav Petkov wrote:
> On Mon, Jul 17, 2017 at 08:21:23PM -0400, Prarit Bhargava wrote:
>> The word "Error" is used by many QA groups and users as a keyword to
>> indicate that there is a critical failure during system bootup. The ESRT
>> code would interact better with these scripts
>
> ... which is a thinly veiled way of saying: my scripts can't
> differentiate between an error being reported and the word "error" so
> let's "fix" the kernel.
>
> Jeez. Fix your scripts instead.
>
Boris, I'd agree with you but this is one of those places where I think we
should bend a bit. Error and Warning are indications of a failure, and we
should consider special casing them. I would agree if this were one or two
scripts but I've heard complaints from 3 different companies about this.
It's a minor fix in the grander scheme of things.
P.
next prev parent reply other threads:[~2017-07-18 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 0:21 [PATCH] acpi/apei/erst: Remove "Error" from initialization and disable output Prarit Bhargava
2017-07-18 5:26 ` Borislav Petkov
2017-07-18 11:29 ` Prarit Bhargava [this message]
2017-07-18 14:07 ` Borislav Petkov
2017-07-18 15:46 ` Linda Knippers
2017-07-18 16:38 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2017-05-02 13:14 Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fb91e9d-5446-aa6e-2eea-c455538c4c1a@redhat.com \
--to=prarit@redhat.com \
--cc=anton@enomsg.org \
--cc=bp@suse.de \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox