public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: Linda Knippers <linda.knippers@hpe.com>
Cc: Prarit Bhargava <prarit@redhat.com>,
	linux-acpi@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	ying.huang@intel.com
Subject: Re: [PATCH] acpi/apei/erst: Remove "Error" from initialization and disable output
Date: Tue, 18 Jul 2017 18:38:17 +0200	[thread overview]
Message-ID: <20170718163817.GA22334@nazgul.tnic> (raw)
In-Reply-To: <0eb11ba0-4923-5c08-d7a5-1c7a29dbfb20@hpe.com>

On Tue, Jul 18, 2017 at 11:46:11AM -0400, Linda Knippers wrote:
> Most ACPI tables are referenced by their 4 letter abbreviations
> anyway so this seems like a simple and helpful change, consistent
> with other ACPI table references.

I guess today is ridiculous ideas day. :-(

When are you guys going to understand that restricting dmesg *wording*
is never going to fly. It is going to be a losing game of whack-a-mole
for you. You can't really enforce it on people to stop using certain
words in dmesg just because it'll break your scripts. I can't believe
we're still *wasting* time talking about this insanity.

So let me point you in a better direction: have you guys heard of printk
loglevels? The number that gets prepended to each line in dmesg?


$ dmesg -r
...

<6>[    4.656173] i801_smbus 0000:00:1f.3: SMBus using PCI interrupt
<3>[    4.657280] irq: Invalid fwnode type (2) for irqdomain
<4>[    4.660181] ACPI Warning: SystemIO range 0x0000000000000428-0x000000000000042F conflicts with OpRegion 0x0000000000000400-0x000000000000047F (\_SB.PCI0.LPC.PMIO) (20170303/utaddress-247)
<6>[    4.662265] ACPI: If an ACPI driver is available for this device, you should use it instead of the native driver

6 is KERN_INFO, 3 is KERN_ERR, 4 is KERN_WARNING and so on.

If you really want to look for errors and warnings, you should use those
loglevels. Like everyone else does. And if messages have the wrong
loglevels, they should be fixed.

This is how it should be done reliably - the stress being on *reliably*
- not by grepping for words.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

  reply	other threads:[~2017-07-18 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18  0:21 [PATCH] acpi/apei/erst: Remove "Error" from initialization and disable output Prarit Bhargava
2017-07-18  5:26 ` Borislav Petkov
2017-07-18 11:29   ` Prarit Bhargava
2017-07-18 14:07     ` Borislav Petkov
2017-07-18 15:46   ` Linda Knippers
2017-07-18 16:38     ` Borislav Petkov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-05-02 13:14 Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170718163817.GA22334@nazgul.tnic \
    --to=bp@suse.de \
    --cc=anton@enomsg.org \
    --cc=ccross@android.com \
    --cc=keescook@chromium.org \
    --cc=lenb@kernel.org \
    --cc=linda.knippers@hpe.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=tony.luck@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox