public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@mvista.com>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: linux-acpi@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Matthew Wilcox <matthew@wil.cx>,
	Peter Zijlstra <peterz@infradead.org>,
	"Zhao, Yakui" <yakui.zhao@intel.com>,
	Dave Chinner <david@fromorbit.com>, Ingo Molnar <mingo@elte.hu>
Subject: RE: [PATCH 4/5] acpi: remove interpreter lock
Date: Thu, 07 Aug 2008 14:09:00 -0700	[thread overview]
Message-ID: <1218143340.19162.40.camel@localhost.localdomain> (raw)
In-Reply-To: <9D39833986E69849A2A8E74C1078B6B3CE1334@orsmsx415.amr.corp.intel.com>

On Thu, 2008-08-07 at 13:32 -0700, Moore, Robert wrote:
> I believe the point was to allow the handler to execute methods, even
> from other threads and to not block the interpreter for an unknown
> amount of time.
> 

Could you elaborate on this more, I'm not following you.. What do you
mean by "handler"? The name "interpreter lock" to me sort of indicates
that it's protecting the interpreter. So I'm guessing the point was to
stop multiple threads from being inside the interpreter at once.

If that's the case it doesn't make sense to release the mutex while your
inside the interpreter. That means another thread could then enter and
the protection doesn't hold.

It looked like most if the interpreter functions allocate their own
memory, then use that memory without sharing it with other instances of
the interpreter. So it's all contained into the one thread. 

You also have the mutexes embedded in the AML , which seem to indicate
the AML is thread safe (might be a big assumption tho).

Daniel


  reply	other threads:[~2008-08-07 21:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-07 14:59 [PATCH 0/3] acpi: semaphore removal -v2 Daniel Walker
2008-08-07 14:59 ` [PATCH 1/5] add mutex_lock_timeout() Daniel Walker
2008-08-07 14:59   ` [PATCH 2/5] acpi: add real mutex function calls Daniel Walker
2008-08-07 14:59     ` [PATCH 3/5] acpi: add lockdep magic Daniel Walker
2008-08-07 14:59       ` [PATCH 4/5] acpi: remove interpreter lock Daniel Walker
2008-08-07 14:59         ` [PATCH 5/5] acpi: semaphore removal Daniel Walker
2008-08-08  0:34           ` Matthew Wilcox
2008-08-08  1:00             ` Daniel Walker
2008-08-08  1:28             ` Dave Chinner
2008-08-08  2:53               ` Matthew Wilcox
2008-08-08  3:47                 ` Daniel Walker
2008-08-08  2:44           ` Andi Kleen
2008-08-08  3:35             ` Daniel Walker
2008-08-07 20:32         ` [PATCH 4/5] acpi: remove interpreter lock Moore, Robert
2008-08-07 21:09           ` Daniel Walker [this message]
2008-08-07 21:30             ` Moore, Robert
2008-08-08  0:01               ` Daniel Walker
2008-08-08  2:40         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218143340.19162.40.camel@localhost.localdomain \
    --to=dwalker@mvista.com \
    --cc=ak@linux.intel.com \
    --cc=david@fromorbit.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=robert.moore@intel.com \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox