From: Dave Chinner <david@fromorbit.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Daniel Walker <dwalker@mvista.com>,
linux-acpi@vger.kernel.org, Robert Moore <robert.moore@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Zhao Yakui <yakui.zhao@intel.com>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 5/5] acpi: semaphore removal
Date: Fri, 8 Aug 2008 11:28:49 +1000 [thread overview]
Message-ID: <20080808012849.GC24344@disturbed> (raw)
In-Reply-To: <20080808003408.GA8618@parisc-linux.org>
On Thu, Aug 07, 2008 at 06:34:08PM -0600, Matthew Wilcox wrote:
> On Thu, Aug 07, 2008 at 07:59:43AM -0700, Daniel Walker wrote:
> > The semaphore usage in ACPI is more like completions. The ASL
> > functions getting implemented here are signals which follow a
> > "wait for", signaled, or reset format.
> >
> > This implements the ACPI signaling methods with the Linux
> > completion API, instead of using semaphores.
> >
> > completion_done() taken from Dave Chinner.
>
> completion_done is an abomination. Stop this.
Say what?
You've had several opportunities to comment on that *you suggested*
[1]. You did not respond to any of them when it was being discussed
6 weeks ago and subsequent resends [2] and now you're saying what
you suggested is an abortion?
What's the problem? The implementation, the interface, or
something else?
[1] http://oss.sgi.com/archives/xfs/2008-06/msg00380.html
[2] http://oss.sgi.com/archives/xfs/2008-06/msg00382.html
http://oss.sgi.com/archives/xfs/2008-06/msg00400.html
http://oss.sgi.com/archives/xfs/2008-07/msg00173.html
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-08-08 1:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 14:59 [PATCH 0/3] acpi: semaphore removal -v2 Daniel Walker
2008-08-07 14:59 ` [PATCH 1/5] add mutex_lock_timeout() Daniel Walker
2008-08-07 14:59 ` [PATCH 2/5] acpi: add real mutex function calls Daniel Walker
2008-08-07 14:59 ` [PATCH 3/5] acpi: add lockdep magic Daniel Walker
2008-08-07 14:59 ` [PATCH 4/5] acpi: remove interpreter lock Daniel Walker
2008-08-07 14:59 ` [PATCH 5/5] acpi: semaphore removal Daniel Walker
2008-08-08 0:34 ` Matthew Wilcox
2008-08-08 1:00 ` Daniel Walker
2008-08-08 1:28 ` Dave Chinner [this message]
2008-08-08 2:53 ` Matthew Wilcox
2008-08-08 3:47 ` Daniel Walker
2008-08-08 2:44 ` Andi Kleen
2008-08-08 3:35 ` Daniel Walker
2008-08-07 20:32 ` [PATCH 4/5] acpi: remove interpreter lock Moore, Robert
2008-08-07 21:09 ` Daniel Walker
2008-08-07 21:30 ` Moore, Robert
2008-08-08 0:01 ` Daniel Walker
2008-08-08 2:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080808012849.GC24344@disturbed \
--to=david@fromorbit.com \
--cc=ak@linux.intel.com \
--cc=dwalker@mvista.com \
--cc=linux-acpi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.moore@intel.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox