linux-next: acpi tree build failure

linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi Len,

Today's (and several previous day's) linux-next build (i386 allmodconfig)
failed like this:

arch/x86/kernel/cpu/cpufreq/longhaul.c: In function 'longhaul_setstate':
arch/x86/kernel/cpu/cpufreq/longhaul.c:308: error: implicit declaration of function 'acpi_set_register'

(http://kisskb.ellerman.id.au/kisskb/target/421/)

Caused by commit e2f34512879026beb26827c14b1d1e67c07f2858 ("ACPICA:
Rename ACPI bit register access functions").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: acpi tree build failure

[Lin Ming]

On Wed, 2009-03-18 at 08:57 +0800, Stephen Rothwell wrote:
> Hi Len,
> 
> Today's (and several previous day's) linux-next build (i386 allmodconfig)
> failed like this:
> 
> arch/x86/kernel/cpu/cpufreq/longhaul.c: In function 'longhaul_setstate':
> arch/x86/kernel/cpu/cpufreq/longhaul.c:308: error: implicit declaration of function 'acpi_set_register'

Please try below patch,


    ACPI: cpufreq: use new bit register access function
    
    Signed-off-by: Lin Ming <ming.m.lin@intel.com>
---
 arch/x86/kernel/cpu/cpufreq/longhaul.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/cpufreq/longhaul.c b/arch/x86/kernel/cpu/cpufreq/longhaul.c
index a4cff5d..4e18d51 100644
--- a/arch/x86/kernel/cpu/cpufreq/longhaul.c
+++ b/arch/x86/kernel/cpu/cpufreq/longhaul.c
@@ -303,7 +303,7 @@ retry_loop:
 		outb(3, 0x22);
 	} else if ((pr != NULL) && pr->flags.bm_control) {
 		/* Disable bus master arbitration */
-		acpi_set_register(ACPI_BITREG_ARB_DISABLE, 1);
+		acpi_write_bit_register(ACPI_BITREG_ARB_DISABLE, 1);
 	}
 	switch (longhaul_version) {
 
@@ -326,7 +326,7 @@ retry_loop:
 	case TYPE_POWERSAVER:
 		if (longhaul_flags & USE_ACPI_C3) {
 			/* Don't allow wakeup */
-			acpi_set_register(ACPI_BITREG_BUS_MASTER_RLD, 0);
+			acpi_write_bit_register(ACPI_BITREG_BUS_MASTER_RLD, 0);
 			do_powersaver(cx->address, clock_ratio_index, dir);
 		} else {
 			do_powersaver(0, clock_ratio_index, dir);
@@ -339,7 +339,7 @@ retry_loop:
 		outb(0, 0x22);
 	} else if ((pr != NULL) && pr->flags.bm_control) {
 		/* Enable bus master arbitration */
-		acpi_set_register(ACPI_BITREG_ARB_DISABLE, 0);
+		acpi_write_bit_register(ACPI_BITREG_ARB_DISABLE, 0);
 	}
 	outb(pic2_mask,0xA1);	/* restore mask */
 	outb(pic1_mask,0x21);


> 
> (http://kisskb.ellerman.id.au/kisskb/target/421/)
> 
> Caused by commit e2f34512879026beb26827c14b1d1e67c07f2858 ("ACPICA:
> Rename ACPI bit register access functions").
> 

Re: linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

Hi Lin,

On Wed, 18 Mar 2009 09:09:01 +0800 Lin Ming <ming.m.lin@intel.com> wrote:
>
> Please try below patch,
> 
> 
>     ACPI: cpufreq: use new bit register access function
>     
>     Signed-off-by: Lin Ming <ming.m.lin@intel.com>

That fixes the build problem - I tested it on top of just today's acpi
test branch (which is what goes into linux-next).  I don't have the
hardware ...

Compile-tested-by: Stephen Rothwell <sfr@canb.auug.org.au>

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: acpi tree build failure

[Len Brown]

applied.
thanks,
Len Brown, Intel Open Source Technology Center

Re: linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

Hi Len,

On Tue, 1 Sep 2009 12:57:48 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/acpi/als.c: In function 'acpi_als_get_mappings':
> drivers/acpi/als.c:173: error: expected ')' before 'PREFIX'
> drivers/acpi/als.c: In function 'acpi_als_add':
> drivers/acpi/als.c:347: error: expected ')' before 'PREFIX'
> 
> I have used the version of the acpi tree from next-20090831 for today.

This is still there ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: acpi tree build failure

[Zhang Rui]

len,

please revert the two ALS patches.

thanks,
rui

On Mon, 2009-09-07 at 21:46 +0800, Stephen Rothwell wrote:
> Hi Len,
> 
> On Tue, 1 Sep 2009 12:57:48 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next build (x86_64 allmodconfig) failed like this:
> > 
> > drivers/acpi/als.c: In function 'acpi_als_get_mappings':
> > drivers/acpi/als.c:173: error: expected ')' before 'PREFIX'
> > drivers/acpi/als.c: In function 'acpi_als_add':
> > drivers/acpi/als.c:347: error: expected ')' before 'PREFIX'
> > 
> > I have used the version of the acpi tree from next-20090831 for today.
> 
> This is still there ...

Re: linux-next: acpi tree build failure

[Len Brown]

> please revert the two ALS patches.

done.

Sorry about the merge-conflict and build error, Stephen.
You can update to the latest acpi-test tree now.

thanks,
-Len Brown, Intel Open Source Technology Center

Re: linux-next: acpi tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

Hi Len,

On Wed, 09 Sep 2009 00:02:03 -0400 (EDT) Len Brown <lenb@kernel.org> wrote:
>
> > please revert the two ALS patches.
> 
> done.
> 
> Sorry about the merge-conflict and build error, Stephen.
> You can update to the latest acpi-test tree now.

Thanks, I will pick it up tomorrow.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]