From: Maxim Levitsky <maximlevitsky@gmail.com>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
Alexey Starikovskiy <astarikovskiy@suse.de>
Subject: Re: [PATCH 3/3] ACPI: battery: register power_supply subdevice even when battery not present
Date: Mon, 07 Sep 2009 05:37:07 +0300 [thread overview]
Message-ID: <1252291027.4627.2.camel@maxim-laptop> (raw)
In-Reply-To: <4A098D0A.6090509@tuffmail.co.uk>
On Tue, 2009-05-12 at 15:51 +0100, Alan Jenkins wrote:
> Keeping this device around lets userspace know that we have a battery
> bay, even if there is nothing in it at the moment. This is what every
> other battery driver does, so ACPI should do it as well.
>
> There is no reason to preserve the old behaviour. We now correctly
> provide the "present" attribute, which will return "0" when the battery
> is removed. HAL was already trying to check this attribute, so
> it should be fine.
>
> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
What happened to this patch?
I still get the issue this patch attempts to fix:
maxim@maxim-laptop:~/software/kernel/linux-2.6$
ls /sys/class/power_supply/
AC
maxim@maxim-laptop:~/software/kernel/linux-2.6$
ls /sys/class/power_supply/
AC BAT0
maxim@maxim-laptop:~/software/kernel/linux-2.6$
ls /sys/class/power_supply/
AC
maxim@maxim-laptop:~/software/kernel/linux-2.6$ uname -r
2.6.31-rc8-next-20090904-next
maxim@maxim-laptop:~/software/kernel/linux-2.6$
When I unplug the battery, its sysfs entry disappears.
Thus if system was booted without battery, there will be no way to know
system has one.
This patch doesn't apply.
Best regards,
Maxim Levitsky
next prev parent reply other threads:[~2009-09-07 2:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 14:51 [PATCH 3/3] ACPI: battery: register power_supply subdevice even when battery not present Alan Jenkins
2009-09-07 2:37 ` Maxim Levitsky [this message]
2009-09-07 12:29 ` Alan Jenkins
2009-10-31 1:58 ` Maxim Levitsky
2009-10-31 10:48 ` Alan Jenkins
2009-10-31 13:20 ` Maxim Levitsky
2009-11-01 18:03 ` Alan Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252291027.4627.2.camel@maxim-laptop \
--to=maximlevitsky@gmail.com \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=astarikovskiy@suse.de \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox