* [BUGFIX] ACPI, APEI, Fix ERST MOVE_DATA instruction implementation
@ 2010-09-15 9:00 Huang Ying
0 siblings, 0 replies; only message in thread
From: Huang Ying @ 2010-09-15 9:00 UTC (permalink / raw)
To: Len Brown
Cc: Javier Martinez Canillas, Andrew Morton,
linux-acpi@vger.kernel.org, LKML, Andi Kleen
The src_base and dst_base fields in apei_exec_context are physical
address, so they should be ioremaped before being used in ERST
MOVE_DATA instruction.
Reported-by: Javier Martinez Canillas <martinez.javier@gmail.com>
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Huang Ying <ying.huang@intel.com>
---
drivers/acpi/apei/erst.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -266,13 +266,27 @@ static int erst_exec_move_data(struct ap
{
int rc;
u64 offset;
+ void *src, *dst;
+
+ /* ioremap does not work in interrupt context */
+ if (in_interrupt())
+ return -EBUSY;
rc = __apei_exec_read_register(entry, &offset);
if (rc)
return rc;
- memmove((void *)ctx->dst_base + offset,
- (void *)ctx->src_base + offset,
- ctx->var2);
+
+ src = ioremap(ctx->src_base + offset, ctx->var2);
+ if (!src)
+ return -ENOMEM;
+ dst = ioremap(ctx->dst_base + offset, ctx->var2);
+ if (!dst)
+ return -ENOMEM;
+
+ memmove(dst, src, ctx->var2);
+
+ iounmap(src);
+ iounmap(dst);
return 0;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-09-15 9:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-15 9:00 [BUGFIX] ACPI, APEI, Fix ERST MOVE_DATA instruction implementation Huang Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox