* [PATCH 2/2] ACPI: Fixed some coding style issues in fan.c and battery.c
@ 2010-12-21 21:41 Jan Füsting
2010-12-21 23:41 ` Thiago Farina
0 siblings, 1 reply; 2+ messages in thread
From: Jan Füsting @ 2010-12-21 21:41 UTC (permalink / raw)
To: lenb; +Cc: linux-acpi, linux-kernel, Jan Füsting
Fixed some coding style issues in fan.c and battery.c
Signed-off-by: Jan Füsting <jan.fuesting@gmx.de>
---
drivers/acpi/battery.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index 16fc4df..35d0c6f 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -580,7 +580,7 @@ static void acpi_battery_quirks(struct acpi_battery *battery)
{
if (dmi_name_in_vendors("Acer") && battery->power_unit)
set_bit(ACPI_BATTERY_QUIRK_SIGNED16_CURRENT, &battery->flags);
-}
+}
/*
* According to the ACPI spec, some kinds of primary batteries can
--
1.7.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/2] ACPI: Fixed some coding style issues in fan.c and battery.c
2010-12-21 21:41 [PATCH 2/2] ACPI: Fixed some coding style issues in fan.c and battery.c Jan Füsting
@ 2010-12-21 23:41 ` Thiago Farina
0 siblings, 0 replies; 2+ messages in thread
From: Thiago Farina @ 2010-12-21 23:41 UTC (permalink / raw)
To: Jan Füsting; +Cc: lenb, linux-acpi, linux-kernel
On Tue, Dec 21, 2010 at 7:41 PM, Jan Füsting <jan.fuesting@gmx.de> wrote:
> Fixed some coding style issues in fan.c and battery.c
>
Which kind of coding style issues you have fixed? Looking at the diff
I couldn't figure out the *issues* as described in the commit message.
Care to resend describing which coding style issues you are fixing?
Also the diff shows a change only in batter.c. Did you forget
something (fan.c) ?
Thanks.
Ah, another thing, you have repeated the subject in the commit
message, if they almost the same except the ACPI, then no need to
repeat it in the commit message.
> Signed-off-by: Jan Füsting <jan.fuesting@gmx.de>
> ---
> drivers/acpi/battery.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index 16fc4df..35d0c6f 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -580,7 +580,7 @@ static void acpi_battery_quirks(struct acpi_battery *battery)
> {
> if (dmi_name_in_vendors("Acer") && battery->power_unit)
> set_bit(ACPI_BATTERY_QUIRK_SIGNED16_CURRENT, &battery->flags);
> -}
> +}
>
> /*
> * According to the ACPI spec, some kinds of primary batteries can
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-21 23:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-21 21:41 [PATCH 2/2] ACPI: Fixed some coding style issues in fan.c and battery.c Jan Füsting
2010-12-21 23:41 ` Thiago Farina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox