From: Toshi Kani <toshi.kani@hp.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tang Chen <tangchen@cn.fujitsu.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
rafael.j.wysocki@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [PATCH] driver core / cpu: Check if NUMA node is valid before bringing CPU up
Date: Mon, 12 Aug 2013 18:37:55 -0600 [thread overview]
Message-ID: <1376354275.10300.361.camel@misato.fc.hp.com> (raw)
In-Reply-To: <12747916.Y6ImPYErWR@vostro.rjw.lan>
On Tue, 2013-08-13 at 02:39 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> There is a potential race condition between cpu_subsys_online()
> and either acpi_processor_remove() or remove_memory() that execute
> try_offline_node(). Namely, it is possible that cpu_subsys_online()
> will run right after the CPUs NUMA node has been put offline and
> cpu_to_node() executed by it will return NUMA_NO_NODE (-1). In
> that case the CPU is gone and it doesn't make sense to call cpu_up()
> for it, so make cpu_subsys_online() return -ENODEV then.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Acked-by: Toshi Kani <toshi.kani@hp.com>
> ---
>
> Hi Greg,
>
> Can you please kindly queue up this one for 3.12?
>
> I've added the Toshi's ACK as he said it looked good to him. :-)
That's fine by me.
-Toshi
next prev parent reply other threads:[~2013-08-13 0:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 10:11 [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic() Yasuaki Ishimatsu
2013-08-06 16:56 ` Toshi Kani
2013-08-07 3:23 ` Yasuaki Ishimatsu
2013-08-09 7:28 ` Tang Chen
2013-08-09 22:16 ` Toshi Kani
2013-08-09 23:29 ` Rafael J. Wysocki
2013-08-10 2:11 ` Toshi Kani
2013-08-11 20:42 ` Rafael J. Wysocki
2013-08-12 20:08 ` Toshi Kani
2013-08-13 0:39 ` [PATCH] driver core / cpu: Check if NUMA node is valid before bringing CPU up Rafael J. Wysocki
2013-08-13 0:37 ` Toshi Kani [this message]
2013-08-09 2:43 ` [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic() Gu Zheng
2013-08-09 5:53 ` Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376354275.10300.361.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=gregkh@linuxfoundation.org \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@sisk.pl \
--cc=tangchen@cn.fujitsu.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox