From: Toshi Kani <toshi.kani@hp.com>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: rafael.j.wysocki@intel.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic()
Date: Tue, 06 Aug 2013 10:56:18 -0600 [thread overview]
Message-ID: <1375808178.10300.181.camel@misato.fc.hp.com> (raw)
In-Reply-To: <5200CBBF.1090904@jp.fujitsu.com>
On Tue, 2013-08-06 at 19:11 +0900, Yasuaki Ishimatsu wrote:
> try_offline_node() checks that all cpus related with removed node have been
> removed by using cpu_present_bits. If all cpus related with removed node have
> been removed, try_offline_node() clears the node information.
>
> But try_offline_node() called from acpi_processor_remove() never clears
> the node information. For disabling cpu_present_bits, acpi_unmap_lsapic()
> need be called. But acpi_unmap_lsapic() is called after try_offline_node()
> runs. So when try_offline_node() runs, the cpu's cpu_present_bits is always
> set.
>
> This patch moves try_offline_node() after acpi_unmap_lsapic().
>
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
The change looks good to me.
Acked-by: Toshi Kani <toshi.kani@hp.com>
BTW, do you know why try_offline_node() has to use stop_machine()?
Thanks,
-Toshi
next prev parent reply other threads:[~2013-08-06 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 10:11 [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic() Yasuaki Ishimatsu
2013-08-06 16:56 ` Toshi Kani [this message]
2013-08-07 3:23 ` Yasuaki Ishimatsu
2013-08-09 7:28 ` Tang Chen
2013-08-09 22:16 ` Toshi Kani
2013-08-09 23:29 ` Rafael J. Wysocki
2013-08-10 2:11 ` Toshi Kani
2013-08-11 20:42 ` Rafael J. Wysocki
2013-08-12 20:08 ` Toshi Kani
2013-08-13 0:39 ` [PATCH] driver core / cpu: Check if NUMA node is valid before bringing CPU up Rafael J. Wysocki
2013-08-13 0:37 ` Toshi Kani
2013-08-09 2:43 ` [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic() Gu Zheng
2013-08-09 5:53 ` Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375808178.10300.181.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox