From: Toshi Kani <toshi.kani@hp.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI/hotplug: Fix STARTING/DYING action in acpi_cpu_soft_notify()
Date: Mon, 19 May 2014 16:57:02 -0600 [thread overview]
Message-ID: <1400540222.18128.6.camel@misato.fc.hp.com> (raw)
In-Reply-To: <2011129.WMiXDPUasW@vostro.rjw.lan>
On Tue, 2014-05-20 at 00:55 +0200, Rafael J. Wysocki wrote:
> On Thursday, May 08, 2014 07:58:59 AM Toshi Kani wrote:
> > During CPU online/offline testing on a large system, one of the
> > processors got stuck after the message "bad: scheduling from the
> > idle thread!". The problem is that acpi_cpu_soft_notify() calls
> > acpi_bus_get_device() for all action types. CPU_STARTING and
> > CPU_DYING do not allow the notify handlers to sleep. However,
> > acpi_bus_get_device() can sleep in acpi_ut_acquire_mutex().
> >
> > Change acpi_cpu_soft_notify() to return immediately for CPU_STARTING
> > and CPU_DYING as they have no action in this handler.
> >
> > Signed-off-by: Toshi Kani <toshi.kani@hp.com>
>
> Queued up for 3.16, thanks!
Great! Thanks Rafael!
-Toshi
prev parent reply other threads:[~2014-05-19 23:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 13:58 [PATCH] ACPI/hotplug: Fix STARTING/DYING action in acpi_cpu_soft_notify() Toshi Kani
2014-05-19 22:55 ` Rafael J. Wysocki
2014-05-19 22:57 ` Toshi Kani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400540222.18128.6.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox