From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Aaron Lu" <aaron.lu@intel.com>,
"Zhang Rui" <rui.zhang@intel.com>, "Len Brown" <lenb@kernel.org>,
"Andre Müller" <andre.muller@web.de>,
Hohahiu <rakothedin@gmail.com>,
linux-acpi@vger.kernel.org, "Hans de Goede" <hdegoede@redhat.com>,
stable@vger.kernel.org.#.3.16
Subject: [PATCH 1/4] acpi-video: Fix use_native_backlight selection logic
Date: Thu, 28 Aug 2014 10:20:45 +0200 [thread overview]
Message-ID: <1409214048-7331-1-git-send-email-hdegoede@redhat.com> (raw)
Commit 751109aad583 ("ACPI / video: Change the default for
video.use_native_backlight to 1") has changed the default for
use_native_backlight from 0 to 1, but instead of changing
use_native_backlight_dmi to true, and leaving use_native_backlight_param at -1,
it has changed use_native_backlight_param to 1.
This causes acpi_video_use_native_backlight() to always think that a value was
specified through the param, making it impossible to add a dmi based quirk
to force 0 now that the default is 1.
This fixes this by restoring the use_native_backlight_param default to -1, and
instead setting the use_native_backlight_dmi default to true.
Cc: stable@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/acpi/video.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 8268843..58bcf7a 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -82,9 +82,9 @@ module_param(allow_duplicates, bool, 0644);
* For Windows 8 systems: used to decide if video module
* should skip registering backlight interface of its own.
*/
-static int use_native_backlight_param = 1;
+static int use_native_backlight_param = -1;
module_param_named(use_native_backlight, use_native_backlight_param, int, 0444);
-static bool use_native_backlight_dmi = false;
+static bool use_native_backlight_dmi = true;
static int register_count;
static struct mutex video_list_lock;
--
2.1.0
next reply other threads:[~2014-08-28 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 8:20 Hans de Goede [this message]
2014-08-28 8:20 ` [PATCH 2/4] acpi-video: Add a disable_native_backlight quirk Hans de Goede
2014-08-28 8:20 ` [PATCH 3/4] acpi-video: Disable native_backlight on HP ENVY 15 Notebook PC Hans de Goede
2014-08-28 8:20 ` [PATCH 4/4] acpi-video: Remove video_set_use_native_backlight quirk Hans de Goede
2014-09-02 21:53 ` [PATCH 1/4] acpi-video: Fix use_native_backlight selection logic Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409214048-7331-1-git-send-email-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=aaron.lu@intel.com \
--cc=andre.muller@web.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rakothedin@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org.#.3.16 \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox