From: Hans de Goede <hdegoede@redhat.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Aaron Lu" <aaron.lu@intel.com>,
"Zhang Rui" <rui.zhang@intel.com>, "Len Brown" <lenb@kernel.org>,
"Andre Müller" <andre.muller@web.de>,
Hohahiu <rakothedin@gmail.com>,
linux-acpi@vger.kernel.org, "Hans de Goede" <hdegoede@redhat.com>,
stable@vger.kernel.org.#.3.16
Subject: [PATCH 2/4] acpi-video: Add a disable_native_backlight quirk
Date: Thu, 28 Aug 2014 10:20:46 +0200 [thread overview]
Message-ID: <1409214048-7331-2-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1409214048-7331-1-git-send-email-hdegoede@redhat.com>
Some laptops have a working acpi_video backlight control, and using native
backlight on these causes a regression where backlight control does not work
when userspace is not handling brightness key events. Disable native_backlight
on these to fix this.
https://bugzilla.kernel.org/show_bug.cgi?id=81691
Reported-and-tested-by: Andre Müller <andre.muller@web.de>
Cc: stable@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/acpi/video.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index 58bcf7a..dd5c302 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -417,6 +417,12 @@ static int __init video_set_use_native_backlight(const struct dmi_system_id *d)
return 0;
}
+static int __init video_disable_native_backlight(const struct dmi_system_id *d)
+{
+ use_native_backlight_dmi = false;
+ return 0;
+}
+
static struct dmi_system_id video_dmi_table[] __initdata = {
/*
* Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121
@@ -720,6 +726,30 @@ static struct dmi_system_id video_dmi_table[] __initdata = {
DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook 8780w"),
},
},
+
+ /*
+ * These models have a working acpi_video backlight control, and using
+ * native backlight causes a regression where backlight does not work
+ * when userspace is not handling brightness key events. Disable
+ * native_backlight on these to fix this:
+ * https://bugzilla.kernel.org/show_bug.cgi?id=81691
+ */
+ {
+ .callback = video_disable_native_backlight,
+ .ident = "ThinkPad T420",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T420"),
+ },
+ },
+ {
+ .callback = video_disable_native_backlight,
+ .ident = "ThinkPad T520",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T520"),
+ },
+ },
{}
};
--
2.1.0
next prev parent reply other threads:[~2014-08-28 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 8:20 [PATCH 1/4] acpi-video: Fix use_native_backlight selection logic Hans de Goede
2014-08-28 8:20 ` Hans de Goede [this message]
2014-08-28 8:20 ` [PATCH 3/4] acpi-video: Disable native_backlight on HP ENVY 15 Notebook PC Hans de Goede
2014-08-28 8:20 ` [PATCH 4/4] acpi-video: Remove video_set_use_native_backlight quirk Hans de Goede
2014-09-02 21:53 ` [PATCH 1/4] acpi-video: Fix use_native_backlight selection logic Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409214048-7331-2-git-send-email-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=aaron.lu@intel.com \
--cc=andre.muller@web.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rakothedin@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org.#.3.16 \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox