From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Colin King <colin.king@canonical.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: video: remove redundant assignments to variable result
Date: Wed, 04 Mar 2020 12:02:39 +0100 [thread overview]
Message-ID: <1811882.qudN6vFfLL@kreacher> (raw)
In-Reply-To: <20200229001243.113176-1-colin.king@canonical.com>
On Saturday, February 29, 2020 1:12:43 AM CET Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable result is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/acpi/acpi_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index 15c5b272e698..bc96457c9e25 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -943,7 +943,7 @@ acpi_video_init_brightness(struct acpi_video_device *device)
> int i, max_level = 0;
> unsigned long long level, level_old;
> struct acpi_video_device_brightness *br = NULL;
> - int result = -EINVAL;
> + int result;
>
> result = acpi_video_get_levels(device->dev, &br, &max_level);
> if (result)
>
Applied as 5.7 material, thanks!
prev parent reply other threads:[~2020-03-04 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 0:12 [PATCH] ACPI: video: remove redundant assignments to variable result Colin King
2020-03-04 11:02 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1811882.qudN6vFfLL@kreacher \
--to=rjw@rjwysocki.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox