* [PATCH] ACPI: video: remove redundant assignments to variable result
@ 2020-02-29 0:12 Colin King
2020-03-04 11:02 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-02-29 0:12 UTC (permalink / raw)
To: Zhang Rui, Rafael J . Wysocki, Len Brown, linux-acpi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable result is being initialized with a value that is never
read and it is being updated later with a new value. The initialization
is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/acpi/acpi_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 15c5b272e698..bc96457c9e25 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -943,7 +943,7 @@ acpi_video_init_brightness(struct acpi_video_device *device)
int i, max_level = 0;
unsigned long long level, level_old;
struct acpi_video_device_brightness *br = NULL;
- int result = -EINVAL;
+ int result;
result = acpi_video_get_levels(device->dev, &br, &max_level);
if (result)
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI: video: remove redundant assignments to variable result
2020-02-29 0:12 [PATCH] ACPI: video: remove redundant assignments to variable result Colin King
@ 2020-03-04 11:02 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-03-04 11:02 UTC (permalink / raw)
To: Colin King
Cc: Zhang Rui, Len Brown, linux-acpi, kernel-janitors, linux-kernel
On Saturday, February 29, 2020 1:12:43 AM CET Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable result is being initialized with a value that is never
> read and it is being updated later with a new value. The initialization
> is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/acpi/acpi_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index 15c5b272e698..bc96457c9e25 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -943,7 +943,7 @@ acpi_video_init_brightness(struct acpi_video_device *device)
> int i, max_level = 0;
> unsigned long long level, level_old;
> struct acpi_video_device_brightness *br = NULL;
> - int result = -EINVAL;
> + int result;
>
> result = acpi_video_get_levels(device->dev, &br, &max_level);
> if (result)
>
Applied as 5.7 material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-04 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-29 0:12 [PATCH] ACPI: video: remove redundant assignments to variable result Colin King
2020-03-04 11:02 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox