From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Andrew Grover
<andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
kernel list
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
ACPI mailing list
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Cc: Patrick Mochel <mochel-3NddpPZAyC0@public.gmane.org>
Subject: More seq-file fixes for /proc/acpi
Date: Thu, 13 Feb 2003 23:39:00 +0100 [thread overview]
Message-ID: <20030213223900.GA141@elf.ucw.cz> (raw)
Hi!
More seq-file fixes. [This is not a dup ;-)] Toshiba maintainer,
please fix your stuff yourself. This should fix all /proc write
problems in acpi I know... Please apply,
Pavel
--- clean/drivers/acpi/processor.c 2003-02-11 17:40:46.000000000 +0100
+++ linux/drivers/acpi/processor.c 2003-02-13 23:16:28.000000000 +0100
@@ -1356,7 +1356,8 @@
loff_t *data)
{
int result = 0;
- struct acpi_processor *pr = (struct acpi_processor *) data;
+ struct seq_file *m = (struct seq_file *)file->private_data;
+ struct acpi_processor *pr = (struct acpi_processor *)m->private;
char state_string[12] = {'\0'};
ACPI_FUNCTION_TRACE("acpi_processor_write_throttling");
@@ -1418,7 +1419,8 @@
loff_t *data)
{
int result = 0;
- struct acpi_processor *pr = (struct acpi_processor *) data;
+ struct seq_file *m = (struct seq_file *)file->private_data;
+ struct acpi_processor *pr = (struct acpi_processor *)m->private;
char limit_string[25] = {'\0'};
int px = 0;
int tx = 0;
--- clean/drivers/acpi/thermal.c 2003-02-11 17:40:46.000000000 +0100
+++ linux/drivers/acpi/thermal.c 2003-02-13 23:17:37.000000000 +0100
@@ -946,11 +948,12 @@
acpi_thermal_write_cooling_mode (
struct file *file,
const char *buffer,
- size_t count,
- loff_t *data)
+ unsigned long count,
+ loff_t *ppos)
{
int result = 0;
- struct acpi_thermal *tz = (struct acpi_thermal *) data;
+ struct seq_file *m = (struct seq_file *)file->private_data;
+ struct acpi_thermal *tz = (struct acpi_thermal *) m->private;
char mode_string[12] = {'\0'};
ACPI_FUNCTION_TRACE("acpi_thermal_write_cooling_mode");
@@ -1006,11 +1009,12 @@
acpi_thermal_write_polling (
struct file *file,
const char *buffer,
- size_t count,
- loff_t *data)
+ unsigned long count,
+ loff_t *ppos)
{
+ struct seq_file *m = (struct seq_file *)file->private_data;
int result = 0;
- struct acpi_thermal *tz = (struct acpi_thermal *) data;
+ struct acpi_thermal *tz = (struct acpi_thermal *) m->private;
char polling_string[12] = {'\0'};
int seconds = 0;
--- clean/drivers/acpi/toshiba_acpi.c 2003-02-11 17:40:46.000000000 +0100
+++ linux/drivers/acpi/toshiba_acpi.c 2003-02-13 23:17:16.000000000 +0100
@@ -519,6 +519,7 @@
if (proc) {
proc->proc_fops = &toshiba_lcd_fops;
proc->proc_fops->write = proc_write_lcd;
+#warning You need to fix up after converting to seq_file; see thermal.c for examples.
}
proc = create_proc_entry(PROC_VIDEO, S_IFREG | S_IRUGO | S_IWUSR,
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
next reply other threads:[~2003-02-13 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-13 22:39 Pavel Machek [this message]
[not found] ` <20030213223900.GA141-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2003-02-14 21:18 ` More seq-file fixes for /proc/acpi John Belmonte
[not found] ` <3E4D5D36.4080100-ZFKsivP1bGvOQU1ULcgDhA@public.gmane.org>
2003-02-14 21:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030213223900.GA141@elf.ucw.cz \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mochel-3NddpPZAyC0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox