From: John Belmonte <jvb-ZFKsivP1bGvOQU1ULcgDhA@public.gmane.org>
To: acpi-devel <acpi-devel-pyega4qmqnRoyOMFzWx49A@public.gmane.org>
Cc: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
Subject: Re: More seq-file fixes for /proc/acpi
Date: Fri, 14 Feb 2003 16:18:46 -0500 [thread overview]
Message-ID: <3E4D5D36.4080100@prairienet.org> (raw)
In-Reply-To: <20030213223900.GA141-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
Pavel Machek wrote:
> More seq-file fixes. [This is not a dup ;-)] Toshiba maintainer,
> please fix your stuff yourself. This should fix all /proc write
> problems in acpi I know... Please apply,
> --- clean/drivers/acpi/toshiba_acpi.c 2003-02-11 17:40:46.000000000 +0100
> +++ linux/drivers/acpi/toshiba_acpi.c 2003-02-13 23:17:16.000000000 +0100
> @@ -519,6 +519,7 @@
> if (proc) {
> proc->proc_fops = &toshiba_lcd_fops;
> proc->proc_fops->write = proc_write_lcd;
> +#warning You need to fix up after converting to seq_file; see thermal.c for examples.
> }
>
> proc = create_proc_entry(PROC_VIDEO, S_IFREG | S_IRUGO | S_IWUSR,
>
I take exception to this. The person who converted my driver to
seq_file should be responsible for finishing the job.
I disagreed with the conversion to seq_file because it doesn't support
an object oriented programming style, as I explained in a posting at the
time the conversion took place.
-John
--
http:// if l . /
-------------------------------------------------------
This SF.NET email is sponsored by: FREE SSL Guide from Thawte
are you planning your Web Server Security? Click here to get a FREE
Thawte SSL guide and find the answers to all your SSL security issues.
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en
next prev parent reply other threads:[~2003-02-14 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-13 22:39 More seq-file fixes for /proc/acpi Pavel Machek
[not found] ` <20030213223900.GA141-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2003-02-14 21:18 ` John Belmonte [this message]
[not found] ` <3E4D5D36.4080100-ZFKsivP1bGvOQU1ULcgDhA@public.gmane.org>
2003-02-14 21:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E4D5D36.4080100@prairienet.org \
--to=jvb-zfksivp1bgvoqu1ulcgdha@public.gmane.org \
--cc=acpi-devel-pyega4qmqnRoyOMFzWx49A@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox