Linux ACPI
 help / color / mirror / Atom feed
* [PATCH] do not compile Sony Vaio extras as a module per default
@ 2006-10-22  6:39 Borislav Petkov
  2006-10-22 10:54 ` Jan Engelhardt
  0 siblings, 1 reply; 5+ messages in thread
From: Borislav Petkov @ 2006-10-22  6:39 UTC (permalink / raw)
  To: akpm; +Cc: linux-kernel, linux-acpi


Signed-off-by: <petkov@math.uni-muenster.de>

--- current/drivers/acpi/Kconfig.orig	2006-10-21 10:02:23.000000000 +0200
+++ current/drivers/acpi/Kconfig	2006-10-21 10:02:30.000000000 +0200
@@ -262,7 +262,6 @@ config ACPI_SONY
 	tristate "Sony Laptop Extras"
 	depends on X86 && ACPI
 	select BACKLIGHT_CLASS_DEVICE
-	default m
 	  ---help---
 	  This mini-driver drives the ACPI SNC device present in the
 	  ACPI BIOS of the Sony Vaio laptops.

-- 
Regards/Gruß,
    Boris.

	

	
		
___________________________________________________________ 
Der frühe Vogel fängt den Wurm. Hier gelangen Sie zum neuen Yahoo! Mail: http://mail.yahoo.de
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] do not compile Sony Vaio extras as a module per default
  2006-10-22  6:39 [PATCH] do not compile Sony Vaio extras as a module per default Borislav Petkov
@ 2006-10-22 10:54 ` Jan Engelhardt
  2006-10-22 16:10   ` Randy Dunlap
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Engelhardt @ 2006-10-22 10:54 UTC (permalink / raw)
  To: petkov; +Cc: akpm, linux-kernel, linux-acpi


>--- current/drivers/acpi/Kconfig.orig	2006-10-21 10:02:23.000000000 +0200
>+++ current/drivers/acpi/Kconfig	2006-10-21 10:02:30.000000000 +0200
>@@ -262,7 +262,6 @@ config ACPI_SONY
> 	tristate "Sony Laptop Extras"
> 	depends on X86 && ACPI
> 	select BACKLIGHT_CLASS_DEVICE
>-	default m
> 	  ---help---
> 	  This mini-driver drives the ACPI SNC device present in the
> 	  ACPI BIOS of the Sony Vaio laptops.

Reason?


	-`J'
-- 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] do not compile Sony Vaio extras as a module per default
  2006-10-22 10:54 ` Jan Engelhardt
@ 2006-10-22 16:10   ` Randy Dunlap
  2006-10-23 12:24     ` Borislav Petkov
  2006-10-23 17:08     ` Borislav Petkov
  0 siblings, 2 replies; 5+ messages in thread
From: Randy Dunlap @ 2006-10-22 16:10 UTC (permalink / raw)
  To: Jan Engelhardt; +Cc: petkov, akpm, linux-kernel, linux-acpi

On Sun, 22 Oct 2006 12:54:30 +0200 (MEST) Jan Engelhardt wrote:

> 
> >--- current/drivers/acpi/Kconfig.orig	2006-10-21 10:02:23.000000000 +0200
> >+++ current/drivers/acpi/Kconfig	2006-10-21 10:02:30.000000000 +0200
> >@@ -262,7 +262,6 @@ config ACPI_SONY
> > 	tristate "Sony Laptop Extras"
> > 	depends on X86 && ACPI
> > 	select BACKLIGHT_CLASS_DEVICE
> >-	default m
> > 	  ---help---
> > 	  This mini-driver drives the ACPI SNC device present in the
> > 	  ACPI BIOS of the Sony Vaio laptops.
> 
> Reason?

This is the third such patch/request that I recall for this
one.  It's =m for Andrew (one of his machines).
Otherwise the patch makes sense and should be merged...

---
~Randy

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] do not compile Sony Vaio extras as a module per default
  2006-10-22 16:10   ` Randy Dunlap
@ 2006-10-23 12:24     ` Borislav Petkov
  2006-10-23 17:08     ` Borislav Petkov
  1 sibling, 0 replies; 5+ messages in thread
From: Borislav Petkov @ 2006-10-23 12:24 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Jan Engelhardt, akpm, linux-kernel, linux-acpi

On Sun, Oct 22, 2006 at 09:10:54AM -0700, Randy Dunlap wrote:
> On Sun, 22 Oct 2006 12:54:30 +0200 (MEST) Jan Engelhardt wrote:
> 
> > 
> > >--- current/drivers/acpi/Kconfig.orig	2006-10-21 10:02:23.000000000 +0200
> > >+++ current/drivers/acpi/Kconfig	2006-10-21 10:02:30.000000000 +0200
> > >@@ -262,7 +262,6 @@ config ACPI_SONY
> > > 	tristate "Sony Laptop Extras"
> > > 	depends on X86 && ACPI
> > > 	select BACKLIGHT_CLASS_DEVICE
> > >-	default m
> > > 	  ---help---
> > > 	  This mini-driver drives the ACPI SNC device present in the
> > > 	  ACPI BIOS of the Sony Vaio laptops.
> > 
> > Reason?
> 
> This is the third such patch/request that I recall for this
> one.  It's =m for Andrew (one of his machines).
> Otherwise the patch makes sense and should be merged...
> 
> ---
> ~Randy

We already turned off the Toshiba extras module some time ago since the majority
of us don't necessarily have the aforementioned machine (see commit
f9a204e1de73a7007de66fb289e1d64a7665c9b4 in Linus' tree) but if this one is
different, then so be it. I still think, though, that it makes more sense to
leave stuff turned on in case it is needed in the most profiles of kernel usage
and leave not so common features off and let people turn them on only for their
special case.

-- 
Regards/Gruß,
    Boris.

		
___________________________________________________________ 
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] do not compile Sony Vaio extras as a module per default
  2006-10-22 16:10   ` Randy Dunlap
  2006-10-23 12:24     ` Borislav Petkov
@ 2006-10-23 17:08     ` Borislav Petkov
  1 sibling, 0 replies; 5+ messages in thread
From: Borislav Petkov @ 2006-10-23 17:08 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Jan Engelhardt, akpm, linux-kernel, linux-acpi

On Sun, Oct 22, 2006 at 09:10:54AM -0700, Randy Dunlap wrote:
> On Sun, 22 Oct 2006 12:54:30 +0200 (MEST) Jan Engelhardt wrote:
> 
> > 
> > >--- current/drivers/acpi/Kconfig.orig	2006-10-21 10:02:23.000000000 +0200
> > >+++ current/drivers/acpi/Kconfig	2006-10-21 10:02:30.000000000 +0200
> > >@@ -262,7 +262,6 @@ config ACPI_SONY
> > > 	tristate "Sony Laptop Extras"
> > > 	depends on X86 && ACPI
> > > 	select BACKLIGHT_CLASS_DEVICE
> > >-	default m
> > > 	  ---help---
> > > 	  This mini-driver drives the ACPI SNC device present in the
> > > 	  ACPI BIOS of the Sony Vaio laptops.
> > 
> > Reason?
> 
> This is the third such patch/request that I recall for this
> one.  It's =m for Andrew (one of his machines).
> Otherwise the patch makes sense and should be merged...
> 
> ---
> ~Randy

(sorry for the duplicate send but the yahoo mailserver is having problems. :()

We already turned off the Toshiba extras module some time ago since the majority
of us don't necessarily have the aforementioned machine (see commit
f9a204e1de73a7007de66fb289e1d64a7665c9b4 in Linus' tree) but if this one is
different, then so be it. I still think, though, that it makes more sense to
leave stuff turned on in case it is needed in the most profiles of kernel usage
and leave not so common features off and let people turn them on only for their
special case.

-- 
Regards/Gruß,
    Boris.
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-10-23 17:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-22  6:39 [PATCH] do not compile Sony Vaio extras as a module per default Borislav Petkov
2006-10-22 10:54 ` Jan Engelhardt
2006-10-22 16:10   ` Randy Dunlap
2006-10-23 12:24     ` Borislav Petkov
2006-10-23 17:08     ` Borislav Petkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox