* [PATCH] ACPI: dock: Send key=value pair instead of plain value
@ 2007-06-11 22:12 Holger Macht
2007-06-11 22:18 ` Kristen Carlson Accardi
2007-07-22 21:07 ` Holger Macht
0 siblings, 2 replies; 3+ messages in thread
From: Holger Macht @ 2007-06-11 22:12 UTC (permalink / raw)
To: lenb; +Cc: Kristen Carlson Accardi, linux-acpi
Send key=value pair along with the uevent instead of a plain value so that
userspace (udev) can handle it like common environment variables.
Signed-off-by: Holger Macht <hmacht@suse.de>
---
Patch applies to recent acpi-test tree
diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index dc3df93..877ca1c 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -336,13 +336,13 @@ static void hotplug_dock_devices(struct
static void dock_event(struct dock_station *ds, u32 event, int num)
{
struct device *dev = &dock_device->dev;
- char event_string[7];
+ char event_string[13];
char *envp[] = { event_string, NULL };
if (num == UNDOCK_EVENT)
- sprintf(event_string, "UNDOCK");
+ sprintf(event_string, "EVENT=undock");
else
- sprintf(event_string, "DOCK");
+ sprintf(event_string, "EVENT=dock");
/*
* Indicate that the status of the dock station has
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ACPI: dock: Send key=value pair instead of plain value
2007-06-11 22:12 [PATCH] ACPI: dock: Send key=value pair instead of plain value Holger Macht
@ 2007-06-11 22:18 ` Kristen Carlson Accardi
2007-07-22 21:07 ` Holger Macht
1 sibling, 0 replies; 3+ messages in thread
From: Kristen Carlson Accardi @ 2007-06-11 22:18 UTC (permalink / raw)
To: Holger Macht; +Cc: lenb, linux-acpi
On Tue, 12 Jun 2007 00:12:00 +0200
Holger Macht <hmacht@suse.de> wrote:
> Send key=value pair along with the uevent instead of a plain value so that
> userspace (udev) can handle it like common environment variables.
>
> Signed-off-by: Holger Macht <hmacht@suse.de>
Acked-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
> ---
>
> Patch applies to recent acpi-test tree
>
> diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
> diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
> index dc3df93..877ca1c 100644
> --- a/drivers/acpi/dock.c
> +++ b/drivers/acpi/dock.c
> @@ -336,13 +336,13 @@ static void hotplug_dock_devices(struct
> static void dock_event(struct dock_station *ds, u32 event, int num)
> {
> struct device *dev = &dock_device->dev;
> - char event_string[7];
> + char event_string[13];
> char *envp[] = { event_string, NULL };
>
> if (num == UNDOCK_EVENT)
> - sprintf(event_string, "UNDOCK");
> + sprintf(event_string, "EVENT=undock");
> else
> - sprintf(event_string, "DOCK");
> + sprintf(event_string, "EVENT=dock");
>
> /*
> * Indicate that the status of the dock station has
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ACPI: dock: Send key=value pair instead of plain value
2007-06-11 22:12 [PATCH] ACPI: dock: Send key=value pair instead of plain value Holger Macht
2007-06-11 22:18 ` Kristen Carlson Accardi
@ 2007-07-22 21:07 ` Holger Macht
1 sibling, 0 replies; 3+ messages in thread
From: Holger Macht @ 2007-07-22 21:07 UTC (permalink / raw)
To: lenb, Kristen Carlson Accardi, linux-acpi
On Tue 12. Jun - 00:12:00, Holger Macht wrote:
> Send key=value pair along with the uevent instead of a plain value so that
> userspace (udev) can handle it like common environment variables.
>
> Signed-off-by: Holger Macht <hmacht@suse.de>
Len, maybe this on accidentally slipped through your attention?
Regards,
Holger
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-22 21:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-11 22:12 [PATCH] ACPI: dock: Send key=value pair instead of plain value Holger Macht
2007-06-11 22:18 ` Kristen Carlson Accardi
2007-07-22 21:07 ` Holger Macht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox