From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Zhang Rui <rui.zhang@intel.com>,
linux-acpi <linux-acpi@vger.kernel.org>,
linux-pm <linux-pm@lists.linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel <linux-kernel@zh-kernel.org>
Subject: Re: [linux-pm] [RFC PATCH 2/4] ACPI: introduce the mechanism to save/restore ACPI NVS memory
Date: Tue, 8 Jul 2008 21:35:59 +0200 [thread overview]
Message-ID: <20080708193558.GC8694@ucw.cz> (raw)
In-Reply-To: <200807040134.15094.rjw@sisk.pl>
Hi!
> > static int acpi_hibernation_begin(void)
> > {
> > acpi_target_sleep_state = ACPI_STATE_S4;
> >
> > - return 0;
> > + /* allocate pages for ACPI NVS memory before swsusp_shrink_memory */
> > + return acpi_allocate_nvs_pages();
>
> I think we shouldn't abort hibernation because of that.
>
> This may be an emergency hibernation due to critical battery status and we
> surely don't want to about that.
I disagree here. If spec says 'you must save this', and we don't, we
are asking for subtle, dangerous, and very hard to repoduce problems.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-07-09 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 2:24 [RFC PATCH 2/4] ACPI: introduce the mechanism to save/restore ACPI NVS memory Zhang Rui
2008-07-03 2:46 ` Zhang Rui
2008-07-03 23:34 ` Rafael J. Wysocki
2008-07-08 19:35 ` Pavel Machek [this message]
2008-07-09 14:58 ` [linux-pm] " Henrique de Moraes Holschuh
2008-07-09 20:26 ` Rafael J. Wysocki
2008-07-09 22:44 ` Pavel Machek
2008-07-10 1:06 ` Zhang Rui
2008-07-10 10:46 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708193558.GC8694@ucw.cz \
--to=pavel@suse.cz \
--cc=andi@firstfloor.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@zh-kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox