From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Len Brown <lenb@kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 3/7] pci: using %pF in quirks.c
Date: Thu, 25 Sep 2008 08:56:57 -0600 [thread overview]
Message-ID: <200809250856.57716.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <1222308277-10984-3-git-send-email-yhlu.kernel@gmail.com>
On Wednesday 24 September 2008 08:04:33 pm Yinghai Lu wrote:
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> ---
> drivers/pci/quirks.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 1f26712..addf2db 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -1689,8 +1689,7 @@ static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f, struct pci_f
> if ((f->vendor == dev->vendor || f->vendor == (u16) PCI_ANY_ID) &&
> (f->device == dev->device || f->device == (u16) PCI_ANY_ID)) {
> #ifdef DEBUG
> - dev_dbg(&dev->dev, "calling ");
> - print_fn_descriptor_symbol("%s\n", f->hook);
> + dev_dbg(&dev->dev, "calling %pF\n", f->hook);
> #endif
> f->hook(dev);
> }
I posted a similar patch already:
http://lkml.org/lkml/2008/8/22/178
Maybe mine was too complicated because it touched more files at once.
Regardless, we need to remove the #ifdef DEBUG because it's no longer
necessary.
next prev parent reply other threads:[~2008-09-25 14:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 2:04 [PATCH 1/7] acpi: don't load acpi_cpufreq if acpi=off Yinghai Lu
2008-09-25 2:04 ` [PATCH 2/7] acpi: remove have_arch_parse_srat in acpi.h Yinghai Lu
2008-09-25 15:01 ` Bjorn Helgaas
2008-09-25 17:10 ` Yinghai Lu
2008-09-25 2:04 ` [PATCH 3/7] pci: using %pF in quirks.c Yinghai Lu
2008-09-25 14:52 ` Jesse Barnes
2008-09-25 14:56 ` Bjorn Helgaas [this message]
2008-09-25 16:20 ` Jesse Barnes
2008-09-25 2:04 ` [PATCH 4/7] mm: print out meminit for memmap Yinghai Lu
2008-09-25 8:35 ` Ingo Molnar
2008-09-25 2:04 ` [PATCH 5/7] x86: fix typo in irq_desc array Yinghai Lu
2008-09-25 8:36 ` Ingo Molnar
2008-09-25 2:04 ` [PATCH 6/7] x86: irq no should not use hex in /proc/interrupts Yinghai Lu
2008-09-25 8:39 ` Ingo Molnar
2008-09-25 2:04 ` [PATCH 7/7] x86: print out irq nr for msi/ht Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809250856.57716.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox