Re: [PATCH 2/7] acpi: remove have_arch_parse_srat in acpi.h

["Yinghai Lu" <yinghai@kernel.org>]

On Thu, Sep 25, 2008 at 8:01 AM, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> On Wednesday 24 September 2008 08:04:32 pm Yinghai Lu wrote:
>> 32bit don't need that anymore
>
> I don't understand the connection between this commit log and
> the patch below.
>
>> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>> ---
>>  include/linux/acpi.h |    8 --------
>>  1 files changed, 0 insertions(+), 8 deletions(-)
>>
>> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
>> index 4d5ec43..8eefaa9 100644
>> --- a/include/linux/acpi.h
>> +++ b/include/linux/acpi.h
>> @@ -95,18 +95,10 @@ int acpi_parse_mcfg (struct acpi_table_header *header);
>>  void acpi_table_print_madt_entry (struct acpi_subtable_header *madt);
>>
>>  /* the following four functions are architecture-dependent */
>> -#ifdef CONFIG_HAVE_ARCH_PARSE_SRAT
>> -#define NR_NODE_MEMBLKS MAX_NUMNODES
>> -#define acpi_numa_slit_init(slit) do {} while (0)
>> -#define acpi_numa_processor_affinity_init(pa) do {} while (0)
>> -#define acpi_numa_memory_affinity_init(ma) do {} while (0)
>> -#define acpi_numa_arch_fixup() do {} while (0)
>> -#else
>>  void acpi_numa_slit_init (struct acpi_table_slit *slit);
>>  void acpi_numa_processor_affinity_init (struct acpi_srat_cpu_affinity *pa);
>>  void acpi_numa_memory_affinity_init (struct acpi_srat_mem_affinity *ma);
>>  void acpi_numa_arch_fixup(void);
>> -#endif
>>
>>  #ifdef CONFIG_ACPI_HOTPLUG_CPU
>>  /* Arch dependent functions for cpu hotplug support */
>
there was some workaround for 32bit numa (srat processing),  and we
removed those workaround, and make 32bit more like 64bit.

now HAVE_ARCH_PARSE_SRAT is not defined in any place.

YH