Linux ACPI
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, stable@kernel.org,
	ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [stable] [PATCH 2/5] thinkpad-acpi: fix LED blinking through timer trigger
Date: Tue, 21 Apr 2009 19:44:26 +0000	[thread overview]
Message-ID: <20090421194426.GD30916@hera.kernel.org> (raw)
In-Reply-To: <1239677054-3221-3-git-send-email-hmh@hmh.eng.br>

* Henrique de Moraes Holschuh (hmh@hmh.eng.br) wrote:
> The set_blink hook code in the LED subdriver would never manage to get
> a LED to blink, and instead it would just turn it on.  The consequence
> of this is that the "timer" trigger would not cause the LED to blink
> if given default parameters.
> 
> This problem exists since 2.6.26-rc1.
> 
> To fix it, switch the deferred LED work handling to use the
> thinkpad-acpi-specific LED status (off/on/blink) directly.
> 
> This also makes the code easier to read, and to extend later.
> 
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: stable@kernel.org

This is still not upstream.

thanks,
-chris

  reply	other threads:[~2009-04-21 19:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14  2:44 [GIT PATCH] thinkpad-acpi late queue Henrique de Moraes Holschuh
2009-04-14  2:44 ` [PATCH 1/5] thinkpad-acpi: silence hotkey enable warning for module parameter Henrique de Moraes Holschuh
2009-04-14  2:44 ` [PATCH 2/5] thinkpad-acpi: fix LED blinking through timer trigger Henrique de Moraes Holschuh
2009-04-21 19:44   ` Chris Wright [this message]
2009-04-22  3:11     ` [stable] " Henrique de Moraes Holschuh
2009-04-25  4:25     ` Henrique de Moraes Holschuh
2009-04-14  2:44 ` [PATCH 3/5] thinkpad-acpi: fix use of MODULE_AUTHOR Henrique de Moraes Holschuh
2009-04-14  2:44 ` [PATCH 4/5] thinkpad-acpi: simplify module autoloading Henrique de Moraes Holschuh
2009-04-14  2:44 ` [PATCH 5/5] thinkpad-acpi: bump up version to 0.23 Henrique de Moraes Holschuh
2009-04-18  5:22 ` [GIT PATCH] thinkpad-acpi late queue Len Brown
     [not found]   ` <alpine.LFD.2.00.0904180122090.30751-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-04-18 13:02     ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090421194426.GD30916@hera.kernel.org \
    --to=chrisw@sous-sol.org \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox