Linux ACPI
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Chris Wright <chrisw@sous-sol.org>
Cc: Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, stable@kernel.org,
	ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [stable] [PATCH 2/5] thinkpad-acpi: fix LED blinking through timer trigger
Date: Sat, 25 Apr 2009 01:25:55 -0300	[thread overview]
Message-ID: <20090425042555.GD17216@khazad-dum.debian.net> (raw)
In-Reply-To: <20090421194426.GD30916@hera.kernel.org>

On Tue, 21 Apr 2009, Chris Wright wrote:
> * Henrique de Moraes Holschuh (hmh@hmh.eng.br) wrote:
> > The set_blink hook code in the LED subdriver would never manage to get
> > a LED to blink, and instead it would just turn it on.  The consequence
> > of this is that the "timer" trigger would not cause the LED to blink
> > if given default parameters.
> > 
> > This problem exists since 2.6.26-rc1.
> > 
> > To fix it, switch the deferred LED work handling to use the
> > thinkpad-acpi-specific LED status (off/on/blink) directly.
> > 
> > This also makes the code easier to read, and to extend later.
> > 
> > Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> > Cc: stable@kernel.org
> 
> This is still not upstream.

It is upstream now, commit 75bd3bf2ade9d548be0d2bde60b5ee0fdce0b127.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  parent reply	other threads:[~2009-04-25  4:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14  2:44 [GIT PATCH] thinkpad-acpi late queue Henrique de Moraes Holschuh
2009-04-14  2:44 ` [PATCH 1/5] thinkpad-acpi: silence hotkey enable warning for module parameter Henrique de Moraes Holschuh
2009-04-14  2:44 ` [PATCH 2/5] thinkpad-acpi: fix LED blinking through timer trigger Henrique de Moraes Holschuh
2009-04-21 19:44   ` [stable] " Chris Wright
2009-04-22  3:11     ` Henrique de Moraes Holschuh
2009-04-25  4:25     ` Henrique de Moraes Holschuh [this message]
2009-04-14  2:44 ` [PATCH 3/5] thinkpad-acpi: fix use of MODULE_AUTHOR Henrique de Moraes Holschuh
2009-04-14  2:44 ` [PATCH 4/5] thinkpad-acpi: simplify module autoloading Henrique de Moraes Holschuh
2009-04-14  2:44 ` [PATCH 5/5] thinkpad-acpi: bump up version to 0.23 Henrique de Moraes Holschuh
2009-04-18  5:22 ` [GIT PATCH] thinkpad-acpi late queue Len Brown
     [not found]   ` <alpine.LFD.2.00.0904180122090.30751-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-04-18 13:02     ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090425042555.GD17216@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=chrisw@sous-sol.org \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox